Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 458004

Summary:	[Hover][HTML] provide navigation hover for HTML files
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	Client	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public
Version:	8.0
Target Milestone:	8.0
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2015-01-20 22:14:58 EST

We should provide hover navigation for any HTML tag that takes a path / URL.

We should also provide hovers to show images / colours / etc.

Comment 1 Michael Rennie

2015-01-20 22:28:44 EST

Pushed a first cut of setting up the service, providing a DOM result manager (so the outline, hover, etc can reuse the parse result at zero extra cost).

To be able to properly locate where we are hovering I have to modify the htmlparser to produce ranges on parsed nodes (currently it only uses line + column which makes it almost impossible to know exactly what we are hovering over). I might also produce a token stream for the parser (unless it already has one I have not seen yet).

First cut: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c69e3f465b72b339ea3f02b7193ed7d3d38bd2ce

Comment 2 Curtis Windatt

2015-01-22 16:58:16 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=58ae29702d183790a88972b54c842751f9148a00
Added logic to determine whether a valid node is being hovered over.

I left the calls to scriptResolver commented out as I was always getting 500 server errors.

Comment 3 Michael Rennie

2015-01-26 14:56:58 EST

Fix: 

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a2995cdd3fdff19a2c2abe12c3b0852113752c97

I retooled the entire thing using the new AST node ranges from bug 458345.

So far there is support to hover over (and try to resolve):

1. href attributes for paths and images
2. src attributes for images
3. base64 images

Additional hover types / refinements can be requested in their own bugs