Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 457987

Summary: [extract method] it should not be allowed to extract if-return statement(s) that return non-void value
Product: [Eclipse Project] JDT Reporter: Jongwook Kim <jongwook.kim>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: jongwook.kim, noopur_gupta
Version: 3.8.1   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug

Description Jongwook Kim CLA 2015-01-20 15:05:28 EST
Suppose that the following if-return statement is extracted and becomes new method n():

----------------------------------------
BEFORE
----------------------------------------
public class C {
	public C m() {
		if(true)
			return new C();
		
		return new C();
	}
}

----------------------------------------
AFTER
----------------------------------------
public class C {
	public C m() {
		n();
		
		return new C();
	}

	private void n() {
		if(true)
			return new C();
	}
}

The code change is "syntactically" wrong, differently from the warning message "... Semantics may not be preserved if you proceed."
Comment 1 Noopur Gupta CLA 2015-01-21 00:47:31 EST
See also: bug 132687.
Comment 2 Eclipse Genie CLA 2019-12-06 18:04:57 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.