Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 457729

Summary: fix undefine in argument.js
Product: [ECD] Orion Reporter: Paul Webster <pwebster>
Component: ClientAssignee: Thea Tian <thea.yier>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: P3 CC: thea.yier
Version: 8.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Windows 8   
URL: https://github.com/TianThea/orion.client
Whiteboard:

Description Paul Webster CLA 2015-01-16 13:22:37 EST 
Add an eslint directive to fix the error.  See http://eslint.org/docs/configuring/

Path: org.eclipse.orion.client / bundles / org.eclipse.orion.client.ui / web / gcli / gcli / argument.js
Comment 1 Thea Tian CLA 2015-01-22 09:44:40 EST 
Add /*eslint-env amd, node*/ before ‘define(function(require, exports, module) ’
and change define(function(require, exports, module) into 
define(/* @callback */ function(require, exports, module)
Comment 2 Paul Webster CLA 2015-01-22 09:58:12 EST 
Thanks Thea.  Please follow the github process and open a pull request.  Then mention the pull request in this bug.

PW
Comment 3 Thea Tian CLA 2015-01-22 10:04:49 EST 
(In reply to Paul Webster from comment #2)
> Thanks Thea.  Please follow the github process and open a pull request. 
> Then mention the pull request in this bug.
> 
> PW

Ok,and I've made a commit of this bug in my github,can you see it?
Thea
Comment 4 Paul Webster CLA 2015-01-22 10:19:25 EST 
You have to enter a Pull Request, and then provide the link to your pull request.  If it wasn't mentioned in the Orion wiki docs, here are the general PR instructions: https://help.github.com/articles/using-pull-requests/

PW