Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 457621

Summary:	Index top elements with "<f>" as parent
Product:	z_Archived	Reporter:	Dawid Pakula <zulus>
Component:	PDT	Assignee:	PHP Core <php.core-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	wywrzal
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/41454 https://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=f60289ab703aac0aa622627ec2d28d27418eddc1
Whiteboard:
Bug Depends on:	457784
Bug Blocks:	467746

Description Dawid Pakula

2015-01-15 11:01:19 EST

For peformance reasons, we should index globals with default qualifier, for example <global>. Search become faster than with bitflag AccGlobal.

Comment 1 Dawid Pakula

2015-01-17 15:30:10 EST

We can't use qualifier without losing some functionalities, but we could use "parent" field (not only for this specific case).

I sent feature request to DLTK team: bug #457784

Comment 2 Eclipse Genie

2015-02-09 11:32:31 EST

New Gerrit change created: https://git.eclipse.org/r/41454

Comment 3 Dawid Pakula

2015-02-19 14:43:03 EST

I modified subject, to index all top elements (non-class const, types and functions with "<f>" set as parent.

Since DTLK 5.1.1 we are able to search by parent field. This will much faster than by bit flag (AccGlobal).

Comment 4 Eclipse Genie

2015-10-28 05:31:52 EDT

Gerrit change https://git.eclipse.org/r/41454 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=f60289ab703aac0aa622627ec2d28d27418eddc1

Comment 5 Dawid Pakula

2015-10-28 05:35:33 EDT

Summary:
global elements have <g> qualifier (PHPCoreConstants.GLOBAL_NAMESPACE)
file elements (functions / variables) have <f> parent (PHPCoreConstants.FILE_PARENT).

Comment 6 Michal Niewrzal

2016-06-09 09:58:39 EDT

Closing.