Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 457100

Summary:	[formatter] Failures with the patch of new formatter design
Product:	[Eclipse Project] JDT	Reporter:	Manoj N Palat <manoj.palat>
Component:	Core	Assignee:	Mateusz Matela <mateusz.matela>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mateusz.matela
Version:	4.5
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	303519

Description Manoj N Palat

2015-01-09 01:14:55 EST

See bug 303519 comment 110

Failures and errors found in some unit test cases - Run 
a) RunDOMTests
  - ASTRewritingStatementsTests.testBug413592 8 NPE errors pointing to one single error
  - few formatter failures) and 
b) RunFormatterRegressionTests (tests 447 and 451)

Additional tests /failure found while testing will be added in this bug rather than the parent bug to avoid clutter

Comment 1 Mateusz Matela

2015-01-09 17:28:15 EST

(In reply to Manoj Palat from comment #0)
> a) RunDOMTests
>   - ASTRewritingStatementsTests.testBug413592 8 NPE errors pointing to one
> single error
>   - few formatter failures) and
There was one simple bug in formatter wrapping, other failures and NPEs happened because the formatter didn't get proper source level in options so code parsing reported errors. I fixed these problems and pushed changes into my github. Shall I upload a new patch now or wait for more changes to accumulate?
> b) RunFormatterRegressionTests (tests 447 and 451)
Oops, that's because Egit doesn't include binary changes in generated patch and these tests are stored in zip files. The only change inside is switching tab_size and indentation_size in the settings file. Can I just upload these zips as a separate file, or do you need a full patch with binary changes (I guess you won't be able to load it if you use Egit)?

Comment 2 Manoj N Palat

2015-01-12 00:23:40 EST

(In reply to Mateusz Matela from comment #1)
> (In reply to Manoj Palat from comment #0)
> > a) RunDOMTests
> >   - ASTRewritingStatementsTests.testBug413592 8 NPE errors pointing to one
> > single error
> >   - few formatter failures) and
> There was one simple bug in formatter wrapping, other failures and NPEs
> happened because the formatter didn't get proper source level in options so
> code parsing reported errors. I fixed these problems and pushed changes into
> my github. Shall I upload a new patch now or wait for more changes to
> accumulate?

Just include this in your next patch once all the changes are accumulated.

> > b) RunFormatterRegressionTests (tests 447 and 451)
> Oops, that's because Egit doesn't include binary changes in generated patch
> and these tests are stored in zip files. The only change inside is switching
> tab_size and indentation_size in the settings file. Can I just upload these
> zips as a separate file, or do you need a full patch with binary changes (I
> guess you won't be able to load it if you use Egit)?

You can upload the zips as separate file.

Comment 3 Manoj N Palat

2015-01-23 05:02:45 EST

Fixed alongwith the commit of bug 303519 comment 125