Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 456816

Summary: editor theme may still be read from cache when theme version has changed
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: ClientAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gheorghe
Version: unspecified   
Target Milestone: 8.0   
Hardware: PC   
OS: All   
Whiteboard:

Description Grant Gayed CLA 2015-01-06 12:29:49 EST 
The theme version is used to indicate when a change has been made to a container theme or an editor theme.  However when a theme version change is detected at page load time, the updated version string is written to the prefs as soon as the current kind of theme (container or editor) has been recomputed.  As a result, when the other kind of theme is accessed sometime later, the theme version string matches the updated version that's now in the prefs, and the cache is read when it likely should not have been.  These two kinds of themes need to store separate versions in the prefs to ensure that they both get updated when the theme version is incremented.