Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 456321

Summary: Backport of the fix for bug 376011 to 4.2.2+ misses commit from bug 376011 comment 21
Product: [Eclipse Project] Platform Reporter: Szymon Ptaszkiewicz <sptaszkiewicz>
Component: UIAssignee: Szymon Ptaszkiewicz <sptaszkiewicz>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert
Version: 4.2.2   
Target Milestone: 4.2.2+   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 376011    
Bug Blocks:    
Attachments:
Description Flags
Testcase none

Description Szymon Ptaszkiewicz CLA 2014-12-30 04:50:24 EST
Created attachment 249656 [details]
Testcase

While backporting the fix for bug 376011 to 4.2.2+ one of the commits was not backported and this causes regression in the R4_2_maintenance branch. I'm opening a new bug since bug 376011 was closed some time ago and I think the regression deserves its own bug. Feel free to mark it as a duplicate of bug 376011 if you prefer to reopen bug 376011.

Steps to reproduce:
1. Start a new workspace using Eclipse SDK 4.2.2.
2. Import the attached project.
3. Start self-hosting.
4. In the main menu click Testcase > Test Browser.
5. In the browser that appears type something in the e-mail field and then hit the tab key.
=> Bug - the tab key should move the cursor to the password field but instead the Outline view is activated. The password field is activated for a very short moment and then focus goes to the Outline view. You can see that if you have something typed in the password field, return with mouse back to the e-mail field and then hit tab - the text in the password field will get selected indicating the cursor was correctly moved to the password field but then focus will go to the Outline view making it impossible to type a new password.

This problem occurs only in the R4_2_maintenance branch, it does not happen in 3.x. I investigated the problem and it turned out that the reason while the tab key does not work as expected is that while backporting the fix for bug 376011 to 4.2.2+, the commit mentioned in bug 376011 comment 21 was never committed to the R4_2_maintenance branch. I have verified that cherry-picking this commit to R4_2_maintenance solves the problem and the tab key correctly moves the cursor to the password field.
Comment 1 Szymon Ptaszkiewicz CLA 2014-12-30 05:33:35 EST
Cherry-pick: https://git.eclipse.org/r/#/c/38836/
Comment 2 Wojciech Sudol CLA 2015-01-07 08:17:14 EST
(In reply to Szymon Ptaszkiewicz from comment #1)
> Cherry-pick: https://git.eclipse.org/r/#/c/38836/

Released to R4_2_maintenance with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=4aa22d479eb307352aa6767d517308511b2bd134.

Thank you Szymon!
Comment 3 Szymon Ptaszkiewicz CLA 2015-01-07 09:06:06 EST
Thank you for quick review!