Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 456055

Summary:	SessionEditorInput is not disposed at table (or tree) editor closing
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Core	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:	Maxime Porhel <maxime.porhel>
Severity:	normal
Priority:	P3	CC:	jessy.mallet, laurent.redor, maxime.porhel
Version:	0.9	Keywords:	triaged
Target Milestone:	2.0.3
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	454887
Bug Blocks:

Description Pierre-Charles David

2014-12-23 04:22:22 EST

+++ This bug was initially created as a clone of Bug #454887 +++

The SessionEditorInput is disposed at diagram closing [1]. But, this is not done for tree or table.

This can cause leak from INavigationHistory and EditorHistory that retain the IEditorInput.

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tree/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/internal/editor/DDiagramEditorImpl.java#n723

Comment 1 Pierre-Charles David

2014-12-23 04:23:59 EST

Cloned from bug #454887 to backport the fix into Sirius 2.0.3.

Note that in addition to commit c6157c8a0958fc90cfdef8c56ee386ebfc30bf6e which fixes this specific issue, commit 9c70c327f2de38dae9e62d24644024696e11af5b which fixes a similar leak should also be backported.

Comment 2 Maxime Porhel

2015-01-15 10:24:24 EST

See: 
 . https://git.eclipse.org/r/39645
 . https://git.eclipse.org/r/39646

Comment 3 Maxime Porhel

2015-01-16 11:26:39 EST

Corrected by commit 305fb1719f60ff1823e2362c9441dfc7bdb2a361 on v2.0.x

Comment 4 Maxime Porhel

2015-01-16 11:53:18 EST

And commit 848bdce232f59031ab944c4b36680cb33442c2a9

Comment 5 Jessy Mallet

2015-01-20 11:19:07 EST

Validated on Sirius Stable pre-2.0.3 (2.0.3-S20150116-162634)

Comment 6 Maxime Porhel

2015-01-22 10:03:25 EST

Available in Sirius 2.0.3.