Bug 455504

Description Tobias Melcher 2014-12-17 10:50:36 EST

Hi colleagues,

I detected that HandlerProxy#setEnabled is called too many times when an editor is closed.
In our application HandlerProxy#setEnabled is called 29036 times on 16 different HandlerProxy instances in the editor close scenario. This is simply too much and slows down performance. I would have expected that HandlerProxy#setEnabled is called exactly once on each instance ==> 16 times.


I think the problem is inside ToolbarManagerRenderer which triggers the call getUpdater().updateContributionItems(...) again and again. 

Could this be improved? An option would be to collect all updateContributionItems requests and trigger it then only once with a small delay.

Something like this:
Runnable updateContributorItemsRunnable=new Runnable() {
		
		@Override
		public void run() {
			getUpdater().updateContributionItems(ALL_SELECTOR);			
		}
	};


void updateRequest(@UIEventTopic(UIEvents.REQUEST_ENABLEMENT_UPDATE_TOPIC) Event eventData) {
	Display.getDefault().timerExec(200,updateContributorItemsRunnable);
}


I tried to reproduce the problem in the current Mars dev build and it seems that it was slightly improved; now HandlerProxy#setEnabled is called 3 or 4 times on each instance. 

What do you think? Does it still make sense to introduce the timerExec call to gain performance?

With best regards,
Tobias