Bugzilla – Full Text Bug Listing
| Summary: | Equinox mars m4 promotion was incomplete | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | David Williams <david_williams> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | konstantin, tjwatson |
| Version: | 4.5 | ||
| Target Milestone: | 4.5 M4 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 455079 | ||
|
Description
David Williams
An interesting problem.
I can't find the original bug, now, but we had a problem where gif files from performance tests were being renamed ... but, all the links to them were not, so quick and easy fix was to not renamed *.gif files. Problem is, this was part of a "one line" regex expression,
if [[ $1 =~ (.*)($oldname)(.*) && ! $1 =~ .*\.gif ]]
which by itself is fine, BUT, immediately after we use the "matching groups" during the rename:
mv "$1" "${BASH_REMATCH[1]}$newlabel${BASH_REMATCH[3]}"
Which, in the end, causes several files were being renamed to simply "MarsM4" (last one "winning").
To make it even more interesting, this would have impacted Eclipse, as well, except that, in our process Eclipse artifacts are rsync'd immediately (but, the site left invisible) so by the time I noticed the problem with the Gifs, and changed the renamedBuild.sh script, the artifacts were already correct, on downloads server, but Equinox is only put on download at the time of announce, so the "second run" artifacts were the ones uploaded.
Interesting, eh?
I've fixed the equinox site, by changing the rename script back to the way it was .. and re-promoting Equinox only.
The longer term (even if it itself is temporary) is to not do the regex all in one line, but to have an initial "if gif" and not enter the original regex at all, it if is a gif file.
As a minor follow up, there is now a "blob" file on equinox download site named "MarsM4". It can be deleted, by someone with sufficient permissions. Konstantin, It seems my email to the dev lists is not "being delivered" correctly, so thought until that's fixed, would at least add you to CC on this bug, so you'd know it was fixed, if you hadn't noticed already. Yep. Saw it was fixed last night. Thanks! |