Bugzilla – Full Text Bug Listing
| Summary: | Quick fix does not work with controlled resources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Stéphane Thibaudeau <stephane.thibaudeau> | ||||
| Component: | Diagram | Assignee: | Project Inbox <sirius.diagram-inbox> | ||||
| Status: | CLOSED FIXED | QA Contact: | Pierre-Charles David <pierre-charles.david> | ||||
| Severity: | normal | ||||||
| Priority: | P4 | CC: | florian.barbin, maxime.porhel, pierre-charles.david | ||||
| Version: | 1.0.1 | Keywords: | triaged | ||||
| Target Milestone: | 3.1.5 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=461740 https://git.eclipse.org/r/69950 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0858d594c7010ef90d50967efe25b0c2d1cd8e48 https://bugs.eclipse.org/bugs/show_bug.cgi?id=493918 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 461740 | ||||||
| Bug Blocks: | 491216 | ||||||
| Attachments: |
|
||||||
Reproduced on master (future 3.0.0M5) Moving out of the 4.0 scope for now, along with all the other issues which were there "by default". This does not mean some of these will not be re-integrated at some point, but for now these issues are not part of the roadmap for 4.0. If you feel strongly about this removal from 4.0 and/or are ready to sponsor the corresponding work, feel free to comment. On the same idea than in Bug 461740, when a validation marker points to a DDiagram which is not contained by the main aird but belongs to a referenced analysis (sub aird or other scenario), the quick fix feature does not work: . the "open editor and goto marker" step does not succeed to open the marked diagram editor, instead it opens a text editor. . the apply quick fix step does not retrieve its target, or it find it in the dummy resource set of the "ErrorEditor" and then it is not able to apply the fix . the revalidate phase, is launched on this same dummy editor, and is not able to relaunch the validation. Gerrit change https://git.eclipse.org/r/69950 was merged to [v3.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0858d594c7010ef90d50967efe25b0c2d1cd8e48 Corrected on 3.1.x Verified on Sirius 3.1.5rc1. Available in Sirius 3.1.5. |
Created attachment 249436 [details] VSM and test project The same quick fix works on a "normal" resource, but when using it with a controlled resource the semantic modification is not done. The problems ar e: - no decorator on element with problem despite the problem actually shows up in Problems view - quick fix does not update the semantic model Steps to reproduce : - import the VSM and test project - in test project, open the diagram on the root EPackage - if the name does not start with an uppercase letter, change it - invoke "validate diagram" - a warning shows up in problems view, a decorator is visible on diagram - invoke the quick fix, the first letter is now in lowercase => OK repeat the same steps on the last EPackage which is in a controlled resource : => warning shows up in problems view : OK => no decorator : KO => quick fix does not do anything : KO Regards, Stephane.