Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 455111

Summary: serverAdapterSites.xml has broken content thus jetty, oracle and cloudfoundry servers not listed
Product: [WebTools] WTP ServerTools Reporter: Max Rydahl Andersen <manderse>
Component: wst.serverAssignee: Elson Yuen <eyuen7>
Status: RESOLVED FIXED QA Contact: Elson Yuen <eyuen7>
Severity: normal    
Priority: P3 CC: jesse.mcconnell, konstantin, nboldt, shr31223
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=330862
https://bugs.eclipse.org/bugs/show_bug.cgi?id=447624
https://git.eclipse.org/r/109266
Whiteboard:
Bug Depends on: 434185    
Bug Blocks:    

Description Max Rydahl Andersen CLA 2014-12-13 03:04:30 EST
When looking at #434185 and #454810 I found that the serverAdapterSites.xml seem to have dead/broken/wrong url for many entries.

I used the following command to 'introspect' them:
"grep url serverAdapterSites.xml | sed -e 's/.*\(http.*\)\".*/\1/g' | xargs -n 1 -I {} curl -L -o /dev/null --silent --head --write-out '%{http_code} %{url_effective}\n' {}site.xml"

missing required site.xml: 
404 http://download.eclipse.org/webtools/updates/site.xml
404 https://webtide.com/eclipse/site.xml
404 http://download.oracle.com/otn_software/oepe/luna/wtp/site.xml
404 http://download.eclipse.org/jetty/updates/jetty-wtp/site.xml
403 http://dist.springsource.com/release/TOOLS/cloudfoundry/site.xml

composite site instead:
200 http://download.eclipse.org/jetty/updates/jetty-wtp/compositeContent.xml
200 http://dist.springsource.com/release/TOOLS/cloudfoundry/compositeContent.xml

Things to note:
download.eclipse.org/webtools look like a site that has content back from 2010 - seems wrong to have that in here?

Having both webtide and jetty site in here seems wrong ? Or do they both ship different jetty adapters ?
Comment 1 Max Rydahl Andersen CLA 2014-12-13 03:06:52 EST
this seem to affect both luna and mars.
Comment 2 Jesse McConnell CLA 2014-12-13 09:33:20 EST
yeah, webtide one can be removed

and jetty-wtp has been parked since we haven't heard of anyone using wtp in years
Comment 3 Nick Boldt CLA 2014-12-13 13:58:13 EST
If bug 434185 gets fixed, then at least the two sites w/ composite site metadata would work, but that doesn't help w/ the URLs which are not update sites. 

Using p2 browser, I get "this is not an update site" errors for these two sites:

No repository found at http://download.oracle.com/otn_software/oepe/luna/wtp.
Unable to read repository at https://webtide.com/eclipse/content.xml.
Comment 4 Max Rydahl Andersen CLA 2014-12-14 04:37:44 EST
sad you parked jetty-wtp. tomcat, wildlfy and glassfish is being used with WTP very heavily.

I guess users can use the default preview server which will use the embedded jetty, correct ?
Comment 5 Jesse McConnell CLA 2014-12-15 11:17:12 EST
that is quite shocking to hear, i have only ever talked with maybe 2 or 3 people out of hundreds that have ever used WTP...almost universally we get feedback that a small main method and embedded usage is easier and faster to work with, and integrating with their unit testing frameworks pretty much seals the deal

interesting!
Comment 6 Max Rydahl Andersen CLA 2014-12-15 14:50:12 EST
It all depends who you ask and dependent on how you work.

We can do both. 

We use arquillian to allow for both embedded and external deployment testing.
Comment 7 Konstantin Komissarchik CLA 2014-12-15 15:30:40 EST
Earlier this year, we (Oracle) have switched from producing a monolithic repository to producing a composite. This allows us to update individual components of the product without rebuilding the whole repository. As the composite repository format is not compatible with WTP server adapter discovery mechanism, we can no longer integrate with this feature.

Please remove the Oracle URL from Luna and Mars catalogs.

http://download.oracle.com/otn_software/oepe/luna/wtp

Users looking for WebLogic, GlassFish and Oracle Cloud tools can install these through Eclipse Marketplace.
Comment 8 Elson Yuen CLA 2015-04-27 15:13:07 EDT
Based on the discussions in this item, here are the list of things that will be changed in the serverAdapterSites.xml on Mars release:
=======================================
The following entries will be removed from the list:
http://download.eclipse.org/webtools/updates/
http://www.webtide.com/eclipse
http://download.oracle.com/otn_software/oepe/luna/wtp/ (this one has already been done as part of bug 464913)

The following entries will remain since the bug 434185 has been fixed to consume composite update site:
http://download.eclipse.org/jetty/updates/jetty-wtp/
http://dist.springsource.com/release/TOOLS/cloudfoundry/
=======================================

For the jetty-wtp, I keep it as is since I think the original reason for removal is that it is a composite update site.  Let me know if you want me to remove that as well or anyone disagree with those changes.
Comment 9 Elson Yuen CLA 2015-04-30 14:13:16 EDT
Changes dropped to master
Comment 10 Eclipse Genie CLA 2017-10-11 16:43:19 EDT
New Gerrit change created: https://git.eclipse.org/r/109266