Bugzilla – Full Text Bug Listing
| Summary: | Our method of find compile logs is extremely inefficient | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | ||
| Version: | 4.5 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
This is the fn-gather-compile-logs function in build-funcitons.shshource. From "watching our build" this is one bottle neck, because it required a lot of "disk access". Much more than is needed, I suspect. I think we ended up with this method because initially, with the prototype, we were "missing" some. So, now it's a "worse than exhaustive' search. Just from the first few lines, I suspect it is "repeating itself" in a "disk and time" consuming fasion: for dot in $( find * -name "@dot.xml" ); do targetDir=$( dirname "$dot" ) echo "Processing $dot in $targetDir" if [ ! -r "$targetDir"/MANIFEST.MF ]; then echo "**Failed to process $dot in $targetDir. Likely compile error. Will try source MANIFEST.MF in directory containing target." targetDir=$( dirname "${targetDir}" ) Plus, it's making a lot of "new sub process" calls; things like "dirname" can be obtained by bash built-in string functions.