Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 454683

Summary: Add better default feedback for FXConnection
Product: [Tools] GEF Reporter: Markus Muehlbrandt <markus.muehlbrandt>
Component: GEF FXAssignee: gef-inbox <gef-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: enhancement    
Priority: P3 CC: matthias.wienand, nyssen
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Markus Muehlbrandt CLA 2014-12-10 04:23:02 EST
The default feedback for a FXConnection is a rectangle. It should be adapted to the line shape.
Comment 1 Matthias Wienand CLA 2014-12-11 05:12:20 EST
There is no default feedback. If you do not bind a Provider<IGeometry> for hover/selection feedback, then you do not get feedback per default at all. There are two default geometry providers available:

 1) VisualOutlineGeometryProvider
 2) VisualBoundsGeometryProvider

The VisualOutlineGeometryProvider returns the underlying geometry for an FXGeometryNode or the curve geometry for an FXConnection, respectively. For other nodes, a rectangle representing the layout-bounds of the node is returned. The VisualBoundsGeometryProvider extends the VisualOutlineGeometryProvider. When the VisualOutlineGeometryProvider returns an ICurve for a given visual, this ICurve is also returned by the VisualBoundsGeometryProvider. For other geometries, the VisualBoundsGeometryProvider returns the bounding box of that geometry.

Therefore, if you bind one of the default geometry providers, then it is impossible for an FXConnection to have rectangular feedback. Perhaps you bind another geometry provider in your project? Or you do not use an FXConnection as the visual? (You could be using a Group which contains the FXConnection. The Group would be the visual then, and you would have to adjust the geometry provider accordingly.)
Comment 2 Alexander Nyßen CLA 2015-09-15 12:31:38 EDT
Resolving this as WORKSFORME, as the framework provides reasonable default geometry providers that can be used.