Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 454573

Summary:	Mistakes in the documentation
Product:	[Modeling] Sirius	Reporter:	Nathalie Lepine <nathalie.lepine>
Component:	Documentation	Assignee:	Florian Barbin <florian.barbin>
Status:	CLOSED FIXED	QA Contact:	Belqassim Djafer <belqassim.djafer>
Severity:	normal
Priority:	P1	CC:	belqassim.djafer, florian.barbin, maxime.porhel, pierre-charles.david
Version:	2.0.0	Keywords:	triaged
Target Milestone:	3.0.0M4
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	454596

Description Nathalie Lepine

2014-12-09 09:07:25 EST

In https://www.eclipse.org/sirius/doc/developer/extensions-provide_tabbar_extensions.html:
in Define a tab-bar extension part:
"Sirius defines several property tester" -> "Sirius defines several property testerS"

in Example part:
"You have to add you menu contribution in the plugin.xml file." -> "You have to add youR menu contribution in the plugin.xml file."

Comment 1 Nathalie Lepine

2014-12-09 09:43:46 EST

In Example part :
<visibleWhen checkEnabled="false">
      <and>
         <with variable="activeEditorId">
            <equals value="org.eclipse.sirius.diagram.part.SiriusDiagramEditorID"/>
         </with>
         <with variable="activeEditor">
             <test property="org.eclipse.sirius.sample.tabbar.isConcernedEditor"/>
         </with>
         <with variable="selection">
            <iterate ifEmpty="false" operator="or">
               <and>
                  <test property="org.eclipse.sirius.diagram.isDDiagramElement"/>
                  <test property="org.eclipse.sirius.sample.tabbar.shouldActivateTabbarExtension"/>
               </and>
            </iterate>
         </with>
      </and>
   </visibleWhen>

should be

<test property="org.eclipse.sirius.diagram.UI.isDDiagramElement"/>

Comment 2 Florian Barbin

2014-12-09 10:53:06 EST

Cloned as bug 454596 to backport into 2.0.x

Comment 3 Florian Barbin

2014-12-09 11:49:05 EST

Gerrit: https://git.eclipse.org/r/#/c/37883/

Comment 4 Maxime Porhel

2014-12-10 02:54:16 EST

Fixed by commit 14436b7116abc103798cbe30b331d2ba0d1a3b68

Comment 5 Belqassim Djafer

2015-04-08 05:03:33 EDT

Verified on Sirius 3.0.0M6

Comment 6 Pierre-Charles David

2015-06-24 11:14:57 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.