Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 454146

Summary:	Move sugiyama-specific abstractions to SugiyamaAlgorithm as nested classes.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF Layout	Assignee:	Matthias Wienand <matthias.wienand>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	3.10.0 (Mars) M4
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2014-12-04 10:55:11 EST

The current separation in algorithms and interfaces makes it hard to infer which interfaces are actually used by which algorithm. There are a lot of abstractions, which are only used within the Sugiyama layout algorithm: CrossingReducers, LayerProviders, and NodeWrapper. We should move them into the SugiyamaLayout class.

Comment 1 Matthias Wienand

2014-12-04 10:57:50 EST

Moved the following interfaces/classes into SugiyamaLayoutAlgorithm:
 - BarycentricCrossingReducer
 -

Comment 2 Matthias Wienand

2014-12-04 10:58:19 EST

Moved the following interfaces/classes into SugiyamaLayoutAlgorithm:
 - BarycentricCrossingReducer
 - DFSLayerProvider
 -

Comment 3 Matthias Wienand

2014-12-04 11:00:34 EST

Moved the following interfaces/classes into SugiyamaLayoutAlgorithm:
 - BarycentricCrossingReducer
 - DFSLayerProvider
 - GreedyCrossingReducer
 - NodeWrapper
 - SimpleLayerProvider
 - SplitCrossingReducer
 - CrossingReducer
 - LayerProvider

Pushed all changes to origin/master. Resolving as fixed in 3.10.0M4.