| Summary: | The last action on router button on tabbar is not correctly retargeted | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Laurent Redor <laurent.redor> | ||||
| Component: | Diagram | Assignee: | Laurent Redor <laurent.redor> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | belqassim.djafer, maxime.porhel, pierre-charles.david | ||||
| Version: | 0.9 | Keywords: | triaged | ||||
| Target Milestone: | 3.0.0M5 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 456753 | ||||||
| Attachments: |
|
||||||
For information, when a diagram is opened, the "Line Style" button has no effect until an action is explicitly launched by expanding the combo (same behavior as "Font Color", "Fill Color", "Line Color" buttons). A fix is proposed here: https://git.eclipse.org/r/37538 The same "pattern" of other Sirius MenuManager (TabbarSelectMenuManager, TabbarDistributeMenuManager, ...) for setDefaultAction(String) and setHandler(IAction) has been used. Fix with commit http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3f28d0bc08b9e19a5587425dbda7d58248c6fb2c Validated on Sirius Stable pre-2.0.3 (2.0.3-S20150116-162634) Verified on Sirius 3.0.0M6 Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0. |
Created attachment 249157 [details] EdgeStyleInTabbar.zip: Use case for steps to reproduce Steps to reproduce: * Import the project from EdgeStyleInTabbar.zip (this project needs to have project org.eclipse.sirius.sample.ecore.design installed) * Open the diagram "root package entities" * Select the edge "toC2" * Select the tool "Rectilinear Style Routing" from the line style combo of the tabbar. * OK: The edge routing is changed and the icon of the line style combo is also changed (rectilinear icon). * Select the diagram * Select the edge "toC3" * OK: The icon of the line style is always the rectilinear icon (the last used tool). * Click on this icon in the tabbar (do not expand the combo). * KO: The edge routing has not changed.