Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 454082

Summary: The last action on router button on tabbar is not correctly retargeted
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: belqassim.djafer, maxime.porhel, pierre-charles.david
Version: 0.9Keywords: triaged
Target Milestone: 3.0.0M5   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 456753    
Attachments:
Description Flags
EdgeStyleInTabbar.zip: Use case for steps to reproduce none

Description Laurent Redor CLA 2014-12-04 03:14:34 EST
Created attachment 249157 [details]
EdgeStyleInTabbar.zip: Use case for steps to reproduce

Steps to reproduce:
* Import the project from EdgeStyleInTabbar.zip (this project needs to have project org.eclipse.sirius.sample.ecore.design installed)
* Open the diagram "root package entities"
* Select the edge "toC2"
* Select the tool "Rectilinear Style Routing" from the line style combo of the tabbar.
* OK: The edge routing is changed and the icon of the line style combo is also changed (rectilinear icon).
* Select the diagram
* Select the edge "toC3"
* OK: The icon of the line style is always the rectilinear icon (the last used tool).
* Click on this icon in the tabbar (do not expand the combo).
* KO: The edge routing has not changed.
Comment 1 Laurent Redor CLA 2014-12-04 04:12:16 EST
For information, when a diagram is opened, the "Line Style" button has no effect until an action is explicitly launched by expanding the combo (same behavior as "Font Color", "Fill Color", "Line Color" buttons).
Comment 2 Laurent Redor CLA 2014-12-04 04:18:51 EST
A fix is proposed here: https://git.eclipse.org/r/37538

The same "pattern" of other Sirius MenuManager (TabbarSelectMenuManager, TabbarDistributeMenuManager, ...) for setDefaultAction(String) and setHandler(IAction) has been used.
Comment 4 Belqassim Djafer CLA 2015-01-19 11:17:03 EST
Validated on Sirius Stable pre-2.0.3 (2.0.3-S20150116-162634)
Comment 5 Belqassim Djafer CLA 2015-04-10 03:57:17 EDT
Verified on Sirius 3.0.0M6
Comment 6 Pierre-Charles David CLA 2015-06-24 11:13:03 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.