Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 453958

Summary:	[performance ui] inappropriate "hard coding" in performance.ui bundle
Product:	[Eclipse Project] Platform	Reporter:	David Williams <david_williams>
Component:	Releng	Assignee:	Platform-Releng-Inbox <platform-releng-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	major
Priority:	P2
Version:	4.5
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	stalebug
Bug Depends on:	451923
Bug Blocks:	374441, 454921

Description David Williams

2014-12-03 01:41:20 EST

+++ This bug was initially created as a clone of Bug #451923 +++

It turns out the "problem" in bug 451923 was that there was some sad cases of "hard coding" ... undoubtedly working fine for the conditions when the program was last used ... but which contradict the documentation and make debugging difficult (as well as simply not working). 

The worse of which was to do a DB query with the "jvm" hard coded to "sun"! 

That's the one that caused "nothing to be found", since we now use "8.0" or similar for the "jvm" value. 

The others appear to only be related to "file names" and similar .. but .. you never know. 

Plus, some of the coding appeared to assume there was a different database for every "base reference" version ... with special (undocumented) naming conventions ... but that is sort of contrary to "using databases", so will need to remove that assumption. 

To make fast progress, I "fixed" bug 451923 by continuing the "hard coding", but with "current values", but it if very important to fix this program sooner rather than later.

Comment 1 David Williams

2014-12-03 01:52:05 EST

To help remember the areas to go back to and "fix correctly" see the "diffs" in the commit for the "quick fix": 

http://git.eclipse.org/c/platform/eclipse.platform.releng.buildtools.git/commit/?id=be3dea9e201cc0c6a21977fdc212c546c81cddb0

Comment 2 David Williams

2014-12-03 01:55:49 EST

I'll also mention, one problem with "fixing correctly" (and, no doubt the reason the hard coding was introduced initially) is that either a great many method signatures will have to change to "pass" all the right variables, or else, a general purpose class/framework will need to be created where "deep" methods will know how to "look up" data that was passed in on command line. Neither is all that hard, but will take some time to do well.

Comment 3 David Williams

2016-08-11 15:24:19 EDT

Doing a mass "reset to default assignee" of 52 bugs to help make clear it will (very likely) not be me working on things I had previously planned to work on. I hope this will help prevent the bugs from "getting lost" in other people's queries. Feel free to "take" a bug if appropriate.

Comment 4 Eclipse Genie

2020-06-29 13:28:12 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.