Bugzilla – Full Text Bug Listing
| Summary: | Validation of VSM should detect variables with empty name | ||
|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Olivier Haegi <olivier.haegi> |
| Component: | Diagram | Assignee: | Project Inbox <sirius.diagram-inbox> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | belqassim.djafer, esteban.dugueperoux, jessy.mallet, maxime.porhel, pierre-charles.david |
| Version: | 2.0.0 | Keywords: | triaged |
| Target Milestone: | 3.0.0M5 | ||
| Hardware: | PC | ||
| OS: | Windows 8 | ||
| See Also: |
https://git.eclipse.org/r/71860 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4edb4623427ecdcb39c99fd63b24b3c083e3307e |
||
| Whiteboard: | |||
| Bug Depends on: | 447669 | ||
| Bug Blocks: | |||
|
Description
Olivier Haegi
The code leading to this issue has been corrected in commit c6b7151a193e20ee63d48326a90f060c6d6edf87 : the Tree/TableToolVariables switch were setting twice the name of containerViewVariable instead of setting the name of containerViewVariabl and containerView. The issue existed during creation of a Table/Tree navigation tool in the VSM editor before Sirius 2.0.0 and cannot occur anymore with Sirius 2.x. Olivier only had to set a name to the ElementSelectVariable without name of its unique TableNavigationTool and he does not have the issue anymore. We could use this issue to provide a validation rule to detect any variable a null or empty name. Step to reproduce the initial issue: . In a VSM with a Table description and a Diagram Description . With Sirius 1.0.x, create a Table Navigation Tool : its element select variable has no name . Create a diagram and a table . Close them . From the diagram, right click the mapping which has the navigation name, and navigate to the table . Close the diagram . Open the diagram from the model explorer . NPE Step to validate the real issue . Create a VSM with a lot of tools . Unset the name of the variables (in textual editor: remove the attribute or put "") . Launch the validate action . All variable without a name (= with a null name or an empty name) should appear in the reported problems. Another or additonal solution could be to control the action of the user on property section and never set a null/empty name to a variable *** Bug 453539 has been marked as a duplicate of this bug. *** currently working on it wating for review : https://git.eclipse.org/r/#/c/39055/ https://git.eclipse.org/r/#/c/39055/ as ce92cde3465243d37a98ecf87c26d708e3d70d01 Fixed. Verified on Sirius 3.0.0M6 Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0. New Gerrit change created: https://git.eclipse.org/r/71860 Gerrit change https://git.eclipse.org/r/71860 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4edb4623427ecdcb39c99fd63b24b3c083e3307e |