Bug 453528

Comment 1 Lars Vogel 2014-11-28 08:21:28 EST

+1

Comment 2 Jonas Helming 2014-12-08 05:33:11 EST

*** Bug 453591 has been marked as a duplicate of this bug. ***

Comment 3 Wim Jongman 2014-12-19 04:49:03 EST

I suggest to leave the current features as they are now and add one additional feature to group them. This leaves the possibility to cherry pick individual spies.

Comment 4 Jonas Helming 2014-12-19 05:38:30 EST

I agree, so we need two new ones, the grouping one and one for the liveeditor

Comment 5 Wim Jongman 2014-12-19 05:58:23 EST

(In reply to Jonas Helming from comment #4)
> I agree, so we need two new ones, the grouping one and one for the liveeditor

Yes. I am working on a patch.

Comment 6 Jonas Helming 2014-12-19 06:02:48 EST

Oh, OK, I also started, but then I will stop this.

Comment 7 Wim Jongman 2014-12-19 06:03:04 EST

(In reply to Wim Jongman from comment #5)
> (In reply to Jonas Helming from comment #4)
> > I agree, so we need two new ones, the grouping one and one for the liveeditor
> 
> Yes. I am working on a patch.

I'm changing the feature name to "Model Spy" and not the "Live Editor"

Comment 8 Jonas Helming 2014-12-19 06:07:16 EST

Please consider to add the js bundle to the model spy feature if you like, see
https://bugs.eclipse.org/bugs/show_bug.cgi?id=453921
I will remove it from the core tools.

Comment 9 Jonas Helming 2014-12-19 06:08:52 EST

Please remove the liveeditor bundle and the spy bundle from the core feature, once the new feature is available

Comment 10 Wim Jongman 2014-12-19 06:20:29 EST

(In reply to Jonas Helming from comment #8)
> Please consider to add the js bundle to the model spy feature if you like,
> see
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=453921
> I will remove it from the core tools.

I'm not sure if we want to do this. Who is maintaining the js stuff?

Comment 11 Wim Jongman 2014-12-19 06:21:39 EST

(In reply to Jonas Helming from comment #9)
> Please remove the liveeditor bundle and the spy bundle from the core
> feature, once the new feature is available

also the js and the org.mozilla.javascript features? Let me do it otherwise I will get conflicts.

Comment 12 Jonas Helming 2014-12-19 06:23:42 EST

I leave that up to you, but there is probably no one maintaining it. It was OK for the participators of the previous discussion to also completly remove the js feature.

js and javascript is already removed (and pushed)

Comment 13 Wim Jongman 2014-12-19 06:26:31 EST

(In reply to Jonas Helming from comment #12)
> I leave that up to you, but there is probably no one maintaining it. It was
> OK for the participators of the previous discussion to also completly remove
> the js feature.
> 
> js and javascript is already removed (and pushed)

Okay. Merged it.

Comment 14 Wim Jongman 2014-12-19 06:55:00 EST

I have pushed it to Gerrit [1]. New update site is here [2]

[1] https://git.eclipse.org/r/38553
[2] https://hudson.eclipse.org/platform/job/eclipse-e4-tools-gerrit/lastSuccessfulBuild/artifact/repository/

Comment 15 Wim Jongman 2014-12-19 11:40:20 EST

Fixed with

http://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=1c71a0faab55b4914c7aa07902814c2df015c469

Comment 16 Wim Jongman 2014-12-19 11:42:16 EST

(In reply to Wim Jongman from comment #15)


Javascript removed from core and NOT added to model spy.