Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 453527

Summary:	Consider disabling all org.eclipse.jdt.apt.core debug options if general debug option is disabled
Product:	[Eclipse Project] JDT	Reporter:	Szymon Ptaszkiewicz <sptaszkiewicz>
Component:	Core	Assignee:	Szymon Ptaszkiewicz <sptaszkiewicz>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, jarthana, manoj.palat, shankhba
Version:	4.5	Flags:	jarthana: review+
Target Milestone:	4.5 M4
Hardware:	All
OS:	All
Whiteboard:

Description Szymon Ptaszkiewicz

2014-11-28 08:11:55 EST

This is a follow up of bug 451902 comment 1: it would be good to adjust the behavior of debug flags so that disabling the general flag org.eclipse.jdt.apt.core/debug disables all debug flags like it is done in other bundles.

Comment 1 Szymon Ptaszkiewicz

2014-11-28 08:16:47 EST

Gerrit review: https://git.eclipse.org/r/#/c/37263/

Comment 2 Jay Arthanareeswaran

2014-12-01 04:07:56 EST

Thanks Szymon, pushed the changed to master:

http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=a64919c0c4ec66879cf77662550d459f0b5a8477

Comment 3 Dani Megert

2014-12-02 11:22:17 EST

This is not good and can cause existing options files to no longer work as expected, e.g. if they only set one option to 'true'.

Please revert that change.

Comment 4 Jay Arthanareeswaran

2014-12-05 05:42:51 EST

(In reply to Dani Megert from comment #3)
> This is not good and can cause existing options files to no longer work as
> expected, e.g. if they only set one option to 'true'.
> 
> Please revert that change.

Done:
http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=06764b62b785bb80863f600397b49c0f2e884a4d

Comment 5 shankha banerjee

2014-12-10 04:32:55 EST

Verified for 4.5 M4 using with build I20141209-2000