Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 453359

Summary:	[quickfix] Polish no-unused-params fixes
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	steve_northover
Version:	unspecified
Target Milestone:	8.0
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2014-11-26 22:36:27 EST

Some polish items to make the fixes better:

1. make sure that for a function expression, the fix to remove the param actually works - right now it seems to just run the @callback fix (bad)

2. since the 'remove param can be a multi-edit (removes doc / define entries as needed) we end up replacing the entire contents of the file. This is not good as it messes up the selection after the fix and undo is useless. We should either chain the edits or prune down the range that we use when we set the text via the editor context.

Comment 1 Michael Rennie

2014-11-26 23:11:17 EST

Fix + tests done in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ea797a090843c1cceaac990c554662b80873af47

and 

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3a258792b8886b669f61cc7ee5a41aeb47923a03

I also merged all of the fixes into one file, which should help prevent plugin load timeouts for the JS bundle in a target site.

Comment 2 Michael Rennie

2015-09-14 12:37:00 EDT

*** Bug 477220 has been marked as a duplicate of this bug. ***