Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 453135

Summary: [server] org.eclipse.orion.server.useradmin can be removed
Product: [ECD] Orion Reporter: Anthony Hunter <ahunter.eclipse>
Component: ServerAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 8.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Anthony Hunter CLA 2014-11-25 00:20:52 EST
Now that the cleanup in Bug 444501 and Bug 444864 is done, the org.eclipse.orion.server.useradmin bundle only has a few miscellaneous classes that can be refactored to other places and the bundle removed.
Comment 1 Anthony Hunter CLA 2015-01-21 12:18:12 EST
(In reply to Anthony Hunter from comment #0)
> Now that the cleanup in Bug 444501 and Bug 444864 is done, the
> org.eclipse.orion.server.useradmin bundle only has a few miscellaneous
> classes that can be refactored to other places and the bundle removed.

The RandomPasswordGenerator is only used by the EmailConfirmationServlet, refactored this code to the servlet bundle with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=e06527ed7ec8ba2cd3e8f5963dea937fc72b4a2f
Comment 2 Anthony Hunter CLA 2015-01-21 12:43:58 EST
(In reply to Anthony Hunter from comment #0)
> Now that the cleanup in Bug 444501 and Bug 444864 is done, the
> org.eclipse.orion.server.useradmin bundle only has a few miscellaneous
> classes that can be refactored to other places and the bundle removed.

Refactored UserEmailUtil to the servlet bundle where is it used with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=214af85821220fa8729a9a91afcc3fcda844f945
Comment 3 Anthony Hunter CLA 2015-01-21 13:01:50 EST
(In reply to Anthony Hunter from comment #0)
> Now that the cleanup in Bug 444501 and Bug 444864 is done, the
> org.eclipse.orion.server.useradmin bundle only has a few miscellaneous
> classes that can be refactored to other places and the bundle removed.

The DiskUsageJob is refactored to the code bundle with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=24bf520732734430fdaefc485837079fc5c48da5
Comment 4 Anthony Hunter CLA 2015-01-21 13:11:41 EST
(In reply to Anthony Hunter from comment #0)
> Now that the cleanup in Bug 444501 and Bug 444864 is done, the
> org.eclipse.orion.server.useradmin bundle only has a few miscellaneous
> classes that can be refactored to other places and the bundle removed.

The UserConstants class is no longer used and can be removed. The UserConstants2 class in the core bundle can now be renamed as the new UserConstants. This refactoring was completed with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=28dba1f720b331da71aaf939f27b4ab10472b829
Comment 5 Anthony Hunter CLA 2015-01-21 13:12:31 EST
The bundle is now removed with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=e23677cef67fae1f7319061258aa5c12a2d8a4ff