Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 453091

Summary: [quickfix] Provide quickfix to remove or doc unused params
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: 7.0   
Target Milestone: 8.0   
Hardware: All   
OS: All   
Whiteboard:

Description Michael Rennie CLA 2014-11-24 11:54:38 EST
We should provide a quickfix to remove / document unused params (and update the linting rule no-unused-params to acknowledge the doc).

The fixes should be:

1. in a define-like case -> remove offending params and literal
2. in a function decl, remove the param + doc (if any)
3. in a function expression, remove param + doc (if any) or add @callback tag (http://usejsdoc.org/tags-callback.html)

also need to make a quickfix test suite
Comment 1 Michael Rennie CLA 2014-11-25 13:28:20 EST
Pushed the part of the fix that will remove the unused params and clean up JSDoc and define calls:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bf7a5590fd25ae32bc836719a98db94d7dfcbaef

Still working on the fix to comment the func expression as a callback