Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 452652

Summary: Wrong last GMF bendpoint in case of target move
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Belqassim Djafer <belqassim.djafer>
Severity: normal    
Priority: P3 CC: belqassim.djafer, pierre-charles.david
Version: 2.0.0Keywords: triaged
Target Milestone: 3.0.0M4   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=437097
Whiteboard:
Bug Depends on:    
Bug Blocks: 454004    
Attachments:
Description Flags
Bugzilla452652.zip: use case for steps to reproduce none

Description Laurent Redor CLA 2014-11-21 08:52:26 EST 
Since the feature bug 437097, there is a bug on edge when moving the target. The computed intersection, used as last point, is computed from the intersection bewteen a line, from the last point to the anchor on the target node, and the target node. The start of the line should be the second to last point (and not the last point).

See org.eclipse.sirius.diagram.ui.graphical.edit.policies.SetConnectionBendpointsAccordingToExtremityMoveCommmand.adaptPointListAndRefPoints(boolean, Point, boolean, Rectangle, Point, Point, PointList), l. 184
Comment 1 Laurent Redor CLA 2014-11-21 08:56:00 EST 
Created attachment 248818 [details]
Bugzilla452652.zip: use case for steps to reproduce

Steps to reproduce:
* Import the project from Bugzilla452652.zip
* Open the diagram myDiagram
* The last point is the same for draw2d and GMF (460, 173).
* Move C2
KO: The last point is not the same for draw2d and GMF.
Comment 2 Laurent Redor CLA 2014-11-21 16:00:05 EST 
Fix proposed here:   https://git.eclipse.org/r/36867
Comment 4 Pierre-Charles David CLA 2014-12-03 08:35:32 EST 
Cloned as bug 454004 to backport in Sirius 2.0.x.
Comment 5 Belqassim Djafer CLA 2015-04-08 09:56:19 EDT 
Verified on Sirius 3.0.0M6
Comment 6 Pierre-Charles David CLA 2015-06-24 11:12:46 EDT 
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.