Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 452515

Summary: Make ReconcilingUnitOfWork injectable
Product: [Modeling] TMF Reporter: Christian Dietrich <christian.dietrich.opensource>
Component: Xtext BacklogAssignee: Project Inbox <tmf.xtext-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jan, sebastian.zarnekow
Version: 2.7.3Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard: v2.8

Description Christian Dietrich CLA 2014-11-20 09:56:04 EST 
It would be nice if ReconcilingUnitOfWork would be injectable into XtextDocument
Comment 1 Jan Koehnlein CLA 2014-11-20 10:18:00 EST 
What would you need this for? From my point of view, this class only exists for technical reasons, i.e. not to introduce new API when allowing AST changes by XtextDocument.modify(IUnitOfWork<T, XtextResource>).
Comment 2 Christian Dietrich CLA 2014-11-20 10:19:58 EST 
The Problem is that the original implementation calls EcoreUtil2.resolveAll which might not be correct in all circumstances. (see our internal support group for more details)
Comment 3 Sebastian Zarnekow CLA 2014-11-20 10:30:20 EST 
Could you provide a patch, Christian?
Comment 4 Christian Dietrich CLA 2014-11-21 01:49:26 EST 
Patch is in Gerrit
Comment 5 Sebastian Zarnekow CLA 2014-11-25 12:31:00 EST 
Merged into master. Thanks Christian.