Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 452463

Summary:	Can't disable auto-save in the editor
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	Editor	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	earl93, gheorghe, Silenio_Quarti
Version:	8.0
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Maciej Bendkowski

2014-11-20 05:58:27 EST

With today's master, I'm unable to disable the auto-save feature. I verified that the settings page is updating all configuration correctly, however the auto-save feature seems to be dismissing them. Same thing for the save interval.

Comment 1 Silenio Quarti

2014-11-20 10:24:44 EST

Do you have the git diff annotations showing in the editor ruler?  The git diff annotations also cause the editor to save when idle.  It is possible to disable the annotations by clicking "Tools -> Diff" in the menu bar.

Comment 2 Maciej Bendkowski

2014-11-20 10:33:16 EST

(In reply to Silenio Quarti from comment #1)
> Do you have the git diff annotations showing in the editor ruler?  The git
> diff annotations also cause the editor to save when idle.  It is possible to
> disable the annotations by clicking "Tools -> Diff" in the menu bar.

Thanks, that seems to fix my problem. Anyway, I don't see the reason why having git diff annotations should require auto-save. Couldn't I have the diff with my index updated after a manual save?

Comment 3 Silenio Quarti

2014-11-20 10:52:27 EST

Other editors update the annotations on the fly. In order to support this we need to save the file since the diffing is done in the server.  I think we should add a settings to turn this behavior on/off.   When off, diffing would be done on save only.

Comment 4 Silenio Quarti

2014-11-20 10:54:06 EST

Insoo, please could add the settings?

Comment 5 Insoo Choo

2014-11-20 13:43:18 EST

Yup , working on it right now

Comment 6 Insoo Choo

2014-11-20 14:33:51 EST

just to clarify, do we want to make a new setting or use the existing auto-save setting to control git-diff behaviour?

Comment 7 Maciej Bendkowski

2014-11-21 06:30:26 EST

I'm diminishing the severity to normal because of the work-around mentioned in comment 1.

Comment 8 Silenio Quarti

2015-05-08 11:48:46 EDT

Diff can be enabled/disabled.