Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 451969

Summary: orion.conf is always moved to archive
Product: [ECD] Orion Reporter: Gorkem Ercan <gorkem.ercan>
Component: ServerAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, eclipse
Version: unspecified   
Target Milestone: 8.0   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Gorkem Ercan CLA 2014-11-17 15:11:16 EST
If I keep my orion.conf file on the workspace it is moved to archive with the following message and lost on the subsequent restarts. I think orion.conf should either not be read from the workspace or should not be moved.

ERROR org.eclipse.orion.server.config - Meta File Error, root contains invalid metadata: file /workspace/orion.conf archived to /workspace/.archive/orion.conf
Comment 1 Rafael Chaves CLA 2014-12-08 07:12:35 EST
Trying Orion 7.0, this always happens for me. Even a fully commented out orion.conf causes it to be deemed as invalid and taken out of the way.

This is what gets logged:

2014-12-08 10:08:52.993 [Worker-0] ERROR org.eclipse.orion.server.config - Meta File Error, root contains invalid metadata: file /home/rafael/cloudfier/repository/orion.conf archived to /home/rafael/cloudfier/repository/.archive/orion.conf

No details on what would be wrong. Note this is running against an existing (4.0)  workspace.
Comment 2 Rafael Chaves CLA 2014-12-08 07:16:00 EST
Ok, there is a workaround. This does not occur if the orion.conf file lives in the current directory, only if it lives in the workspace (even if a brand-new one). Is that option no longer supported?
Comment 3 John Arthorne CLA 2014-12-08 08:16:42 EST
Our expected usage is that orion.conf lives in the application root directory alongside the executable. I didn't even remember that it could be read from the workspace, but I see now this is mentioned in the server admin guide.

With our changes to support multiple concurrent instances of Orion, we have been moving away from using the platform instance location for anything important other than OSGi bundle state. I think we should just stop supporting orion.conf in workspace location, and support only pwd and a location specific by system property.

Paul if you agree, can you change the server code to stop checking workspace location, and update the server admin guide doc.
Comment 4 Gorkem Ercan CLA 2014-12-08 09:45:44 EST
I was using this scenario to mostly feed configuration to a dockerized orion to test different settings. It is probably not a production scenario though
Comment 5 Rafael Chaves CLA 2014-12-08 10:10:15 EST
The Orion install should be disposable, but not the configuration, so it'd be better if it did not have to live alongside the executable.

Luckily, at list on Linux, I can have a symbolic link outside of the orion install pointing to the executable inside the install, and the configuration file can be alongside this file, so I'm good.
Comment 6 Rafael Chaves CLA 2014-12-08 10:11:02 EST
...alongside this *link*, I meant.
Comment 7 Paul Webster CLA 2014-12-08 10:15:27 EST
It's server side code that moves the orion.conf to .archive.  Anthony, would another option be to ignore orion.conf in the workspace root, just like we ignore .metadata?

PW
Comment 8 Rafael Chaves CLA 2014-12-08 10:22:02 EST
"and support only pwd and a location specific by system property"

Either of those two approaches are good from my viewpoint.
Comment 9 Anthony Hunter CLA 2014-12-08 13:07:38 EST
(In reply to Paul Webster from comment #7)
> It's server side code that moves the orion.conf to .archive.  Anthony, would
> another option be to ignore orion.conf in the workspace root, just like we
> ignore .metadata?
> 
> PW

Yes, I have delivered this update with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=137a6805b95cf95de1c791693cbabfe4bf7244ad