Bugzilla – Full Text Bug Listing
| Summary: | It should be possible to customize property cell editors in Sirius | ||
|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Esteban DUGUEPEROUX <esteban.dugueperoux> |
| Component: | Diagram | Assignee: | Florian Barbin <florian.barbin> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | belqassim.djafer, cedric.brun, esteban.dugueperoux, florian.barbin, jfbraz, laurent.redor, pierre-charles.david |
| Version: | 1.0.0 | Keywords: | triaged |
| Target Milestone: | 3.0.0M6 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/40432 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=96ecae77c9b57d5a76bb2f3d54f758e9fd8ff994 |
||
| Whiteboard: | |||
| Bug Depends on: | 438123 | ||
| Bug Blocks: | |||
|
Description
Esteban DUGUEPEROUX
Aren't the property source provided by the AdapterFactory used in the property view ? Are you refering to the property view or something else ? Hi Cedric, Jean-François Brazeau will answer you as soon as. Best Regards. Jean-François confirmed that this is about making sure the CellEditor defined in the (potentialy customized) .edit implementation of an Ecore model gets used in the "Semantic" tab of Sirius. It would essentially means that the code in org.eclipse.sirius.diagram.ui.tools.internal.properties.SemanticPropertySection would have to use an AdapterFactoryContentProvider leveraging the adapter factory and use getPropertySource( on this adapterfactorycontentprovider instead of instantiating a PropertySource (though we should probably keep that as a fall back) This AdapterFactoryContentProvider should probably not be instantiated each time as it *might* listen to changes and do something or we need to make sure we can dispose it so that it gets removed from the list of listeners of the adapterfactory. I recall some discussions in EMF core itself about this issue : See https://bugs.eclipse.org/bugs/show_bug.cgi?id=438123 WARNING: this patchset contains 1014 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1014 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1015 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1017 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Gerrit change https://git.eclipse.org/r/40432 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=96ecae77c9b57d5a76bb2f3d54f758e9fd8ff994 WARNING: this patchset contains 1017 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Committed on Master. Verified on Sirius 3.0.0M6 Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0. |