Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 450448

Summary:	Ensure that IDs matching CompassPt keywords are not syntax highlighted.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF DOT	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	3.10.0 (Mars) M4
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2014-11-07 04:38:51 EST

As part of bug #430132 we fixed that CompassPt enum literal values can be used as identifiers (which is legal according to http://www.graphviz.org/doc/info/lang.html). However, the editor still syntax highlights these keywords. We should adjust this to ensure these are only highlighted where appropriate.

As an example, consider that in the following graph definition, "s" will be highlighted as a keyword:

digraph s {
}

Comment 1 Alexander Nyßen

2014-11-12 03:55:42 EST

Add lexical and semantical syntax coloring support:

- Refactored grammar to differentiate different ID tokens (string, quoted string, and numeral; html-style ids not yet supported)
- Added lexical syntax coloring support that highlights lexer tokens properly (and ensures CompassPt values are not handled as keywords)
- Added semantical syntax coloring support, so syntax coloring can be changed via preferences.

All changes pushed to origin/master. Resolving this as fixed in 3.10.0M4.