Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 449979

Summary: [MacOS] Oomph installer crashes on exit
Product: [Tools] Oomph Reporter: Karsten Thoms <karsten.thoms>
Component: SetupAssignee: Project Inbox <oomph-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kelly, stepper
Version: 1.3.0Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Bug Depends on:    
Bug Blocks: 459836, 464937    
Attachments:
Description Flags
Screenshot: Crash Dialog
none
Crash Log
none
Crash Log (new)
none
JVM Crash Dump Log
none
Crash Log (1.1.0 Build 1407) none

Description Karsten Thoms CLA 2014-11-04 11:33:06 EST
When I close the Oomph installer (Mac OSX), a crash report dialog pops up. This is not critical, since Oomph did already its job. It is just ugly.
Comment 1 Karsten Thoms CLA 2014-11-04 11:33:33 EST
Created attachment 248377 [details]
Screenshot: Crash Dialog
Comment 2 Karsten Thoms CLA 2014-11-04 11:33:55 EST
Created attachment 248378 [details]
Crash Log
Comment 3 Eike Stepper CLA 2014-11-04 12:55:16 EST
I hope that I can reproduce it tomorrow on my Mac virtual box, otherwise I fear there's not much I can say regarding without a Java stack trace...
Comment 4 Karsten Thoms CLA 2014-11-05 05:52:59 EST
Sure. The problem is that AFAIK there is no Java stacktrace.
Something must be different in the shutdown procedure. I never experienced this issue with any of my Eclipse instances.
Comment 5 Karsten Thoms CLA 2014-11-05 14:18:31 EST
I have now a reproducable path. The crash does not occur everytime you close Oomph. It occurs repeatable once the Installation Folder is selected. If this dialog was not used before, no crash occurs. So to reproduce:
1) Open Oomph Installer
2) Select Eclipse Product (Standard SDK,Luna)
3) Next -> Skip Project Selection -> Next
4) Click "Browse" button for Installation location
5) Select some folder and leave dialog
6) Press Cancel button

In the product log there is no entry added, only the crash report from Mac. I have recently upgraded to OSX Yosemite.
Comment 6 Ed Merks CLA 2014-11-09 06:33:15 EST
And by close you mean using the close button?  Or using "esc"?  Or is there a Quit menu item on the menubar?  Do all these things cause the same problem?
Comment 7 Karsten Thoms CLA 2014-11-10 02:56:01 EST
By "close" I meant the Cancel button. But also with "Esc" and the red close button in the title the same happens.
If I choose "Quit Oomph Installer" from the menu bar, the application does not crash, only with any other means to close it.
Comment 8 Ed Merks CLA 2014-11-11 07:13:31 EST
I can't reproduce this on my Mac VM.  Generally a VM crash is a VM bug, although it can be caused by bugs in native DLLs too...

Which version/build of Java is being used? If you switch to a different version (with a -vm in the *.ini) does it still have the same problem?
Comment 9 Karsten Thoms CLA 2014-11-13 07:24:50 EST
Default on my system is 1.7.0_21. Tested with 1.8.0_25 and 1.6.0_65 with same effect.
Comment 10 Eike Stepper CLA 2014-12-18 02:37:34 EST
Moving all open bugzillas to 1.1.0.
Comment 11 Eike Stepper CLA 2015-01-13 00:53:33 EST
It's possible that this was fixed by either bug 448860 or bug 457245. Karsten, can you please test this again and reopen this bug if the problem persists?

*** This bug has been marked as a duplicate of bug 457245 ***
Comment 12 Karsten Thoms CLA 2015-01-13 03:55:02 EST
Created attachment 249888 [details]
Crash Log (new)
Comment 13 Karsten Thoms CLA 2015-01-13 03:55:30 EST
Sorry, the problem still occurs with Build#775
Comment 14 Eike Stepper CLA 2015-01-13 04:36:03 EST
Jeesh, I have no clue what that means ;-(

Sorry, for closing to quickly.
Comment 15 Steffen Pingel CLA 2015-01-13 10:50:03 EST
I this possible a duplicate of 457243? Karsten can you start the installer from the command line and check if there is output related to "JDWP Transport"?
Comment 16 Eike Stepper CLA 2015-01-14 04:58:15 EST
Karsten, maybe you can try it without installing these Code Recommenders things; just to see if that makes a difference?
Comment 17 Karsten Thoms CLA 2015-01-14 15:12:54 EST
Created attachment 249949 [details]
JVM Crash Dump Log

I do not see anything which relates to JDWP Transport.

I started now from command line and am getting:
oomph.app/Contents/MacOS/oomph
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00000001212b8ce9, pid=965, tid=24579
#
# JRE version: Java(TM) SE Runtime Environment (8.0_25-b17) (build 1.8.0_25-b17)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.25-b02 mixed mode bsd-amd64 compressed oops)
# Problematic frame:
# C  [libswt-cocoa-4509.jnilib+0x25ce9]  callback+0x297


From this I suspect a problem with the Mac specific SWT implementation. The mentioned dynamic library "libswt-cocoa-4509.jnilib" that runs into an error is located in the fragment org.eclipse.swt.cocoa.macosx.x86_64_3.104.0.v20141210-0658.jar

I tried to replace org.eclipse.swt and org.eclipse.swt.cocoa.macosx with a version from another Eclipse instance (replace the jars and update bundles.info), but same result.

It must have something to do with the "Installation location" folder selection dialog.

In the code I recognized that you are doing some Cocoa related stuff in InstallerApplication and CocoaUtil. In latter you are accessing internal API. I don't know about the intention behind this. Maybe you are allocating some stuff in CocoaUtil#register, which requires a deregistration on shut down?
Comment 18 Eike Stepper CLA 2015-01-15 01:33:22 EST
The CocoaUtil makes the "about", "preferences" and "quit" items of the Mac system menu functional. I've tested it (i.e. the entire installer) on my Mac virtual box.

Nevertheless I've added a system property to skip this CocoaUtil.register() stuff. Please wait for build #794 and add this to your oomph.ini to test:

  -Doomph.cocoa.menu.skip=true
Comment 19 Karsten Thoms CLA 2015-01-15 13:51:57 EST
Tested again with build#803 and adding the system property. I can confirm that the CocoaUtil is not called, since with that option the preferences dialog does not open with CMD+;
But again, the same problem happens.
Comment 20 Eike Stepper CLA 2015-06-08 01:41:12 EDT
Karsten, is this still an issue for you?
Comment 21 Karsten Thoms CLA 2015-06-09 04:31:26 EDT
Created attachment 254220 [details]
Crash Log (1.1.0 Build 1407)

I'm afraid this still happens with the newest build
Comment 22 Eike Stepper CLA 2015-09-05 11:12:14 EDT
Moving all unresolved bugzillas to 1.2.0...
Comment 23 Eike Stepper CLA 2015-10-13 03:03:21 EDT
Moving all unresolved bugzillas to 1.3.0...
Comment 24 Karsten Thoms CLA 2015-11-11 07:22:00 EST
The issue finally does not happen anymore on my machine. It is not reproducable with 1.1.0 Build 1751 and 1.3.0 Build 1816.