Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 449167

Summary:	Remove Acceleo3 references in Sirius Metamodels
Product:	[Modeling] Sirius	Reporter:	Belqassim Djafer <belqassim.djafer>
Component:	Core	Assignee:	Project inbox <sirius.core-inbox>
Status:	CLOSED FIXED	QA Contact:	Belqassim Djafer <belqassim.djafer>
Severity:	normal
Priority:	P3	CC:	florian.barbin, laurent.redor, maxime.porhel, pierre-charles.david
Version:	1.0.1	Keywords:	triaged
Target Milestone:	3.0.0M4
Hardware:	PC
OS:	Windows NT
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=449193
Whiteboard:

Description Belqassim Djafer

2014-10-29 06:37:35 EDT

Try to remove all Acceleo 3 expression in Sirius Metamodels.
This is all Acceleo 3 references in Sirius MM :
- org.eclipse.sirius.viewpoint.description.impl.DescriptionPackageImpl.initEAttribute()
- InterpolatedColorImpl.COLOR_VALUE_COMPUTATION_EXPRESSION_EDEFAULT (Ligne 85)
- EdgeStyleDescriptionImpl.SIZE_COMPUTATION_EXPRESSION_EDEFAULT (Ligne 167)
- StylePackageImpl.initEAttribute() (Ligne 1313)

Comment 1 Belqassim Djafer

2014-10-29 06:49:45 EDT

Proposed fix : https://git.eclipse.org/r/#/c/35631/

Comment 2 Pierre-Charles David

2014-11-03 11:43:01 EST

Fix merged as aac5656f5a52cf59edbf12c41641e224c330cd4b.

Comment 3 Laurent Redor

2014-11-04 06:19:31 EST

There is regression on tests since this fix. Indeed, This fix modifies the behavior of the existing VSMs that use the default values.

A migration participant (AbstractVSMMigrationParticipant) must be added to explicitly replace each default value by the old expression.
People which does not want to depend on Acceleo3 can then update their VSM by removing the A3 expressions.
A documentation must be added in the release notes to explain this and detail the method to remove A3 expressions.

Example of failing test: org.eclipse.sirius.tests.swtbot.sequence.MessageExtensionTest-->The editor should not be dirty after the diagram opening.

Comment 4 Belqassim Djafer

2014-11-06 04:43:41 EST

I propose this migration fix : https://git.eclipse.org/r/#/c/36006/

Comment 5 Laurent Redor

2014-11-07 11:44:29 EST

Regression fixed by [1] (patch from Belqassim).

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6476822c3e7a5c79dc242823ef627bb1024731de

Comment 6 Laurent Redor

2014-11-12 04:25:33 EST

The migration added to fix regression (comment 5) needs changes in "migration framework" (in API) so the 'backport' keyword was removed from the whiteboard list.

Comment 7 Maxime Porhel

2014-11-20 12:07:41 EST

Issue reopened: a migration test is needed with data in the "do not migrate" folder.

Comment 8 Laurent Redor

2014-12-03 09:01:59 EST

Test added with http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f217147fd0c0c9288799718ed46a825709a44557

Comment 9 Maxime Porhel

2015-01-05 08:40:07 EST

The commit bcaf4295b2e16bcc9fa2d37d7e68fd673591f90d makes the Representation file migration also use the new mechanism.

Comment 10 Maxime Porhel

2015-01-05 08:40:14 EST

The commit bcaf4295b2e16bcc9fa2d37d7e68fd673591f90d makes the Representation file migration also use the new mechanism.

Comment 11 Belqassim Djafer

2015-04-09 03:57:29 EDT

Verified as technical issue

Comment 12 Pierre-Charles David

2015-06-24 11:16:56 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.