Bugzilla – Full Text Bug Listing
| Summary: | Problems with matching bracket annotations | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Silenio Quarti <Silenio_Quarti> |
| Component: | Editor | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 5.0 | ||
| Target Milestone: | 8.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Silenio Quarti
From Chris Khoun: 1. Bracket highlighting is done in red and right border annotation is also marked in red (collide with error annotations). 2. Duplicate matching bracket and duplicate current bracket entries under annotation. 3. Curly brackets are used where the script has round brackets. 4. Current bracket is opening even though the script current bracket is closing. Matching bracket is closing even though the script matching bracket is opening. 5. Left clicking the annotation makes the annotation disappear because the left click causes the cursor location to change to the beginning of the line where there are no brackets. This commit should address issues 1, 3 and 4. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1cd8c3f5e7796449633dedc6e6d156afa132fb08 The matching bracket annotations are no longer red. The presentation in the text is also changed to highlight both brackets. The icon shown in the tooltip is not related to the specific bracket. It is just a representation of the matching bracket operation. The icon has been changed to avoid confusion. To be clear, the icon cannot be a specific bracket because on HTML files matching is actually done for opening/closing HTML tags (not brackets). I cannot reproduce issue 2) in latest code. Please reopen if you still can reproduce it with the latest orion. Issue 5) is expected and is not going to be fixed. On the latest, clicking on the annotation selects the annotation range. |