Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 448725

Summary:	NPE when snippet preview is displayed and user clicks outside
Product:	z_Archived	Reporter:	Johannes Dorn <johannes.dorn>
Component:	Recommenders	Assignee:	Project inbox <recommenders-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P5	CC:	marcel.bruch, sewe
Version:	unspecified	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Johannes Dorn

2014-10-24 10:25:43 EDT

1. Search for a snippet. 
2. Wait until the snippet preview is visible.
3. Click outside so that the snipmatch window closes.
4. An NPE occurs



java.lang.NullPointerException
	at org.eclipse.swt.widgets.Control.resetVisibleRegion(Control.java:3278)
	at org.eclipse.swt.widgets.Canvas.resetVisibleRegion(Canvas.java:350)
	at org.eclipse.swt.widgets.Shell.invalidateVisibleRegion(Shell.java:1239)
	at org.eclipse.swt.widgets.Shell.setWindowVisible(Shell.java:2015)
	at org.eclipse.swt.widgets.Shell.setVisible(Shell.java:1936)
	at org.eclipse.jdt.internal.ui.text.java.hover.SourceViewerInformationControl.setVisible(SourceViewerInformationControl.java:329)
	at org.eclipse.jface.text.AbstractInformationControlManager.hideInformationControl(AbstractInformationControlManager.java:1242)
	at org.eclipse.jface.text.contentassist.AdditionalInfoController.hideInformationControl(AdditionalInfoController.java:582)
	at org.eclipse.jface.text.contentassist.PopupCloser.handleEvent(PopupCloser.java:216)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1087)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4184)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1471)
	at org.eclipse.swt.widgets.Shell.windowDidBecomeKey(Shell.java:2159)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5675)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:214)
	at org.eclipse.swt.widgets.Widget.becomeKeyWindow(Widget.java:366)
	at org.eclipse.swt.widgets.Shell.becomeKeyWindow(Shell.java:525)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5499)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:221)
	at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:2105)
	at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2329)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5691)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:5128)
	at org.eclipse.swt.widgets.Display.applicationProc(Display.java:5277)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:128)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3655)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)

Comment 1 Johannes Dorn

2014-10-24 10:42:09 EDT

Apparently, this doesn't happen on Windows.

Comment 2 Johannes Dorn

2014-10-24 11:25:16 EDT

And it doesn't happen on Linux, either. Just Mac OS X.

Comment 3 Andreas Sewe

2015-06-01 09:39:10 EDT

(In reply to Johannes Dorn from comment #1)
> Apparently, this doesn't happen on Windows.

(In reply to Johannes Dorn from comment #2)
> And it doesn't happen on Linux, either. Just Mac OS X.

I can confirm that this no longer occur with the latest 2.2.0 milestones and Eclipse Mars RC3. Marking as fixed.