Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 448710

Summary: Grid-based layout algorithms reserve too much space.
Product: [Tools] GEF Reporter: Matthias Wienand <matthias.wienand>
Component: GEF LayoutAssignee: gef-inbox <gef-inbox>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: nyssen
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
SugiyamaLayoutAlgorithm reserves too much space
none
Sugiyama layout example - Neon M7. none

Description Matthias Wienand CLA 2014-10-24 09:26:52 EDT
Created attachment 248155 [details]
SugiyamaLayoutAlgorithm reserves too much space

Some of the algorithms in GEF4 Layout are grid-based, i.e. they compute an internal grid on which nodes are layed out (GridLayoutAlgorithm, SugiyamaLayoutAlgorithm). When computing the internal grid, too much space is reserved to lay out nodes. This leads to undesirable free space in the bottom and right canvas area as you can see in the attached screenshot.
Comment 1 Alexander Nyßen CLA 2016-05-07 03:05:21 EDT
I have taken a closer look into GridLayoutAlgorithm. Indeed, it does not reserve too much space, but all nodes are placed with top-left alignment within their respective grid cell. I have opened bug #493178 to keep track of enhancing GridLayoutAlgorithm respectively).
Comment 2 Alexander Nyßen CLA 2016-05-07 03:08:09 EDT
Created attachment 261532 [details]
Sugiyama layout example - Neon M7.
Comment 3 Alexander Nyßen CLA 2016-05-07 03:09:13 EDT
The SugiyamaLayoutAlgorithm in contrast places nodes to be center-aligned. As demonstrated by the screenshot, it now seems to place nodes as desired. I assume that here, the problem was not related to the layout algorithm, but to some problem within Zest. 

Resolving this as INVALID.