Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 447957

Summary:	[git] jgit RevisionSyntaxException on the server
Product:	[ECD] Orion	Reporter:	Anthony Hunter <ahunter.eclipse>
Component:	Server	Assignee:	Bogdan Gheorghe <gheorghe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	gheorghe
Version:	unspecified
Target Milestone:	8.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Anthony Hunter

2014-10-20 11:23:15 EDT

Occurs eight times in the latest logs on orion.eclipse.org:

!ENTRY org.eclipse.orion.server.core 4 0 2014-10-20 10:37:38.335
!MESSAGE 
!STACK 0
java.lang.reflect.InvocationTargetException
        at sun.reflect.GeneratedMethodAccessor71.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.eclipse.orion.server.core.resources.ReflectionHelper.callGetter(ReflectionHelper.java:54)
        at org.eclipse.orion.server.core.resources.JSONSerializer.serialize(JSONSerializer.java:27)
        at org.eclipse.orion.server.core.resources.JSONSerializer.serialize(JSONSerializer.java:1)
        at org.eclipse.orion.server.git.objects.Branch.toJSON(Branch.java:93)
        at org.eclipse.orion.server.git.jobs.ListBranchesJob.performJob(ListBranchesJob.java:169)
        at org.eclipse.orion.server.core.tasks.TaskJob.performJob(TaskJob.java:100)
        at org.eclipse.orion.server.core.tasks.TaskJob.run(TaskJob.java:118)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: org.eclipse.jgit.errors.RevisionSyntaxException:refs/remotes/Chris's Github/problemViewer
        at org.eclipse.jgit.lib.Repository.resolve(Repository.java:707)
        at org.eclipse.jgit.lib.Repository.resolve(Repository.java:385)
        at org.eclipse.orion.server.git.objects.Branch.getRemotes(Branch.java:140)
        ... 11 more
Root exception:
org.eclipse.jgit.errors.RevisionSyntaxException:refs/remotes/Chris's Github/problemViewer
        at org.eclipse.jgit.lib.Repository.resolve(Repository.java:707)
        at org.eclipse.jgit.lib.Repository.resolve(Repository.java:385)
        at org.eclipse.orion.server.git.objects.Branch.getRemotes(Branch.java:140)
        at sun.reflect.GeneratedMethodAccessor71.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.eclipse.orion.server.core.resources.ReflectionHelper.callGetter(ReflectionHelper.java:54)
        at org.eclipse.orion.server.core.resources.JSONSerializer.serialize(JSONSerializer.java:27)
        at org.eclipse.orion.server.core.resources.JSONSerializer.serialize(JSONSerializer.java:1)
        at org.eclipse.orion.server.git.objects.Branch.toJSON(Branch.java:93)
        at org.eclipse.orion.server.git.jobs.ListBranchesJob.performJob(ListBranchesJob.java:169)
        at org.eclipse.orion.server.core.tasks.TaskJob.performJob(TaskJob.java:100)
        at org.eclipse.orion.server.core.tasks.TaskJob.run(TaskJob.java:118)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Bogdan Gheorghe

2014-10-27 15:27:44 EDT

This is caused by a bogus remote name - git doesn't allow any spaces in the name (so in this case "Chris's Github" is invalid).

Added checking to catch this case on both the client side and server and erased the original remote that was causing this problem.