Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445902

Summary: Handle preCallbacks in git page to defer the command.callback.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon, Michael_Rennie
Version: 5.0   
Target Milestone: 7.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2014-10-03 16:17:06 EDT 
The compare widget has the save feature but we need to handle all the cases in the git page, if there are any dirty editors in the page we have to defer the command callback.

For example, if there is dirty compare widgets in the RHS, any command that is trying to refresh the RHS has to be deferred till user confirms that they want to save or just stay.
Comment 3 Michael Rennie CLA 2014-10-09 11:03:33 EDT 
This fix breaks the 'View on site' page
Comment 4 Michael Rennie CLA 2014-10-09 11:04:49 EDT 
(In reply to Michael Rennie from comment #3)
> This fix breaks the 'View on site' page

line 139:

this._renderer.initRow(children[i], row);

ViewOnSiteRenderer does not have an initRow function
Comment 6 Mark Macdonald CLA 2014-10-09 13:27:03 EDT 
^