Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445391

Summary: [Occurrences] Refactor occurrences support
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Michael Rennie CLA 2014-09-29 14:46:12 EDT 
As we add new support for marking different kinds of nodes / ids the code to do the AST work is becoming very large and cumbersome, we should refactor it to make it more manageable.

1. we should do a quick check to find the AST node that is currently selected before we start visiting the entire AST, this will give us hints about what kind of occurrences to look for and in what scope(s)

2. using the info from 1. we can then have separate visitors that are used for only one purpose rather than one gigantic visitor with tonnes of branching logic in it.

3. this will also make hooking this up to rename / refactoring much easier
Comment 1 Michael Rennie CLA 2015-05-08 10:41:04 EDT 
We have been improving it over time in various commits, I am going to close this wontfix.