Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445390

Summary:	"Product export" and "Delta Pack" should create its own Mac resources.
Product:	z_Archived	Reporter:	Gunnar Wagenknecht <gunnar>
Component:	Tycho	Assignee:	Project Inbox <tycho-inbox>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	jan.sievers
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=429536
Whiteboard:

Description Gunnar Wagenknecht

2014-09-29 14:37:50 EDT

(From Bug 429536)

I'm not sure of the original rationale, but it seems that to export a product on "multiple platforms" (using delta pack) that function gets the eclipse.ini and PList.info (and, perhaps the directory name of "Eclipse.app"? 

We tried removing "resources" from equinox executable feature (since conceptually they don't belong there ... they belong with product definition). (See bug 429093) and we have move those resources either directly to product definition, in "tychoeclipsebuilder" or to "rcp.config". 

But, removing these "Plist.info" and "eclipse.ini" (and the directory name, with upper case 'E' in "Eclipse.app", from org.eclipse.equinox.executable has had an unexpected effect on "export products for multiple platforms". 

Seems to me that the "export products" already creates some of its product-specific files ... so ... not sure why it should not also create "Eclipse.app" and Plist.info? 

[Sorry this bug is a  bit vague and rambling ... but, I'm not that familiar with "delta pack", and if it was up to me alone, we'd do away with it :) ] (bug 419246)

Comment 1 Jan Sievers

2014-09-30 03:42:46 EDT

Tycho relies on the binaries in the equinox executable (we have a hrdcoded dependency on it) feature because the p2 product publisher needs them as an argument

See
http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-p2/tycho-p2-publisher-plugin/src/main/java/org/eclipse/tycho/plugins/p2/publisher/PublishProductMojo.java#n256

As of now this is the only way for us to get the launcher binaries. Not sure if this should rather be fixed in p2.

Comment 2 Tobias Oberlies

2014-09-30 07:21:39 EDT

Sorry I don't understand a word of what you are talking about. This may be because you created a bug as an exact copy of bug 429536 - and so it doesn't make any sense in the Tycho context. Could you please be more specific about what you want from Tycho?

Comment 3 Gunnar Wagenknecht

2014-09-30 08:33:33 EDT

I copy and pasted the text from David. To my understanding, the launchers will change. They already changed in Luna. The icons were removed. For Mars, David also plans on removing the Info.plist file as well as the launcher.ini from the executables. This only leaves the binary file in place but without an Info.plist and the ini file.

Bug 429536 was opened by David to make sure that PDE Build can deal with that. I opened this bug in Tycho in order also make Tycho aware of these changing coming in Mars. If there is nothing more to deal with from a Tycho perspective then this should be fine.

FWIW, I also prefer that this is dealt with in the p2 world.

Comment 4 Tobias Oberlies

2014-10-01 08:33:16 EDT

(In reply to comment #3)
> FWIW, I also prefer that this is dealt with in the p2 world.
So what is the bug number that traces the changes needed in p2?

Comment 5 Gunnar Wagenknecht

2014-10-01 08:42:06 EDT

(In reply to Tobias Oberlies from comment #4)
> (In reply to comment #3)
> > FWIW, I also prefer that this is dealt with in the p2 world.
> So what is the bug number that traces the changes needed in p2?

I don't know. I believe the Platform team will do its investigation using bug 429536.