Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445214

Summary: Roll back to use server git Diff blocks in git page.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cdtbog, gheorghe
Version: 5.0   
Target Milestone: 7.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2014-09-26 13:30:09 EDT
Ken found that when he compare two huge files(200+K) with a lot of huge chunks of diffs, the compare widget is very slow. It responses after 20-30 seconds.
I did some investigation and found that the reason is because of my recent changes that use the pure client side diff engine for DIFF BLOCKS.
We need to use the git diff from server again. But for WORD level diffs we still have to use client side diff because server does not support that level.
I tried to roll back in my self hosting and it was much faster for Ken's case.
Comment 1 libing wang CLA 2014-09-26 13:33:36 EDT
TO clarify:
There are still client side support in two levels: Block and WORD.
We are just turning off the block level jsdiff in git pages.
In order to support the "ignore white space" feature we need the server to return "ignore white space" diff in the block level.
Comment 2 Bogdan Gheorghe CLA 2014-09-26 18:08:02 EDT
The server side support for this is out. I added a commented out line in resourceCompare to show what needs to be passed in.