Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445195

Summary:	Edge reconnection should modify the previous bendpoints as less as possible
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Diagram	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	laurent.redor, maxime.porhel
Version:	unspecified	Keywords:	triaged
Target Milestone:	2.0.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/42769 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0ebac71b7a1e4e6042b1988460afae64dbd8df27 https://git.eclipse.org/r/43135 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=151a12924ab008881abdf3139ebabe5542d78543
Whiteboard:
Bug Depends on:	445179, 453061
Bug Blocks:

Description Steve Monnier

2014-09-26 09:18:45 EDT

Currently, reconnecting an edge resets the bendpoints positions to default once reconnected. Following the evolution https://bugs.eclipse.org/bugs/show_bug.cgi?id=444057 on reconnection only the last bendpoint, or two last bendpoints depending  on the routing style, should move. This way the previous edge layout will be kept once reconnected.

Comment 1 Maxime Porhel

2014-09-29 04:20:36 EDT

Steve porposed a patch, see https://git.eclipse.org/r/#/c/33960.

Comment 2 Steve Monnier

2014-09-30 09:04:09 EDT

The patch has been pushed on git. SWTBot test are needed in order to resolve this bugzilla.

Comment 3 Steve Monnier

2014-10-06 05:17:10 EDT

SWTBot tests are waiting for review at https://git.eclipse.org/r/#/c/34404/

Comment 4 Steve Monnier

2014-10-14 13:05:22 EDT

Fixed

Comment 5 Laurent Redor

2014-10-22 12:03:52 EDT

A new scenario has been found and correspond to this issue: see bug 445179.

Comment 6 Steve Monnier

2014-10-24 08:48:38 EDT

The issue that led to the reopening of this bugzilla is already filed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=445179

Comment 7 Laurent Redor

2014-10-24 08:51:51 EDT

Only one problem has been detected and as said by Steve in comment 6, another issue exists for it.

Comment 8 Pierre-Charles David

2014-10-27 06:52:09 EDT

Available in Sirius 2.0.0.

Comment 9 Eclipse Genie

2015-02-26 09:35:37 EST

New Gerrit change created: https://git.eclipse.org/r/42769

Comment 10 Eclipse Genie

2015-02-27 10:33:38 EST

Gerrit change https://git.eclipse.org/r/42769 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0ebac71b7a1e4e6042b1988460afae64dbd8df27

Comment 11 Eclipse Genie

2015-03-04 05:42:09 EST

New Gerrit change created: https://git.eclipse.org/r/43135

Comment 12 Eclipse Genie

2015-03-04 06:03:40 EST

Gerrit change https://git.eclipse.org/r/43135 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=151a12924ab008881abdf3139ebabe5542d78543