Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 445179

Summary: When moving edge extremity in inner container, all bendpoints are moved
Product: [Modeling] Sirius Reporter: Belqassim Djafer <belqassim.djafer>
Component: DiagramAssignee: Steve Monnier <steve.monnier>
Status: CLOSED FIXED QA Contact: Belqassim Djafer <belqassim.djafer>
Severity: normal    
Priority: P3 CC: laurent.redor, maxime.porhel, pierre-charles.david
Version: unspecifiedKeywords: triaged
Target Milestone: 3.0.0M4   
Hardware: PC   
OS: Windows NT   
Whiteboard:
Bug Depends on:    
Bug Blocks: 445195, 453061    
Attachments:
Description Flags
Bendpoint_stability none

Description Belqassim Djafer CLA 2014-09-26 05:20:38 EDT
Created attachment 247383 [details]
Bendpoint_stability

When moving edge (style manhattan) extremity in inner container, all bendpoints are moved. This should not happen. Only the two first/last bendpoints should move.

To reproduce :
1- Import the attached project
2- Open bendpointsStability_Manhatta
3- Drag the source extremity edge between "ContainerWithOneNode" to "ContainerWithOneNode2" and drod them to the "Root" container.
4- All bendpoints were updated. This Drap&Drop action should not move the edge bendpoints.

This issue is produced with the Sirius dev version (next 2.0)
Comment 1 Belqassim Djafer CLA 2014-10-23 03:16:47 EDT
This is a correction of the steps to reproduces described in the descriptions :
1- Import the attached project
2- Open bendpointsStability_Manhatta
3- Try to reconnect the source extremity of the edge between "ContainerWithOneNode" to "ContainerWithOneNode2" to the "Root" container which is the parent of "ContainerWithOneNode" to "ContainerWithOneNode2".
4- All bendpoints were updated. This reconnect action should not move the edge bendpoints.
Comment 2 Belqassim Djafer CLA 2014-10-23 08:48:19 EDT
The bendpoints move is visual only, when close and reopen representation, bendpoints are reset to the previous (normal) state.
Comment 3 Steve Monnier CLA 2014-11-06 13:09:03 EST
Waiting for review https://git.eclipse.org/r/#/c/36062/
Test addition: ReconnectEdgeBendpointStabilityTest.testReconnectEdgeWithBadGMFBendpointAndNoReconnectionCandidate()
Comment 4 Steve Monnier CLA 2014-11-12 09:49:08 EST
fix and test committed (commit adf28c7)
Comment 5 Pierre-Charles David CLA 2014-11-24 10:16:09 EST
Cloned as bug 453061 to backport for 2.0.2.
Comment 6 Belqassim Djafer CLA 2015-04-09 05:29:10 EDT
Verified on Sirius 3.0.0M6
Comment 7 Pierre-Charles David CLA 2015-06-24 11:16:51 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.