Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 444885

Summary:	Syntax error at EOL not shown
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	6.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2014-09-23 18:05:26 EDT

1. Paste this code into a JS file and save:

function f() {
	var x;/
}

2. I expected to see a parse error complaining about the unclosed regex literal, but nothing shows up in the editor.

A similar problem happens for this bogus code, which makes me think it has something to do with a syntax error at the end of a line:

function f() {`

}

Comment 1 Michael Rennie

2014-09-29 15:00:29 EDT

That would be because we are failing:

"TypeError: Cannot read property 'type' of null
    at match (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1941:25)
    at parseFunctionSourceElements (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3430:17)
    at parseFunctionDeclaration (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3533:16)
    at parseSourceElement (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3599:24)
    at parseSourceElements (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3639:29)
    at parseProgram (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3656:16)
    at Object.parse (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3921:23)
    at ASTManager.Objects.mixin.parse (http://mrennie-target.orion.eclipse.org:8080/javascript/astManager.js:70:27)
    at http://mrennie-target.orion.eclipse.org:8080/javascript/astManager.js:58:21
    at settleDeferred (http://mrennie-target.orion.eclipse.org:8080/orion/Deferred.js:70:28)"

Comment 2 Michael Rennie

2014-09-29 15:09:01 EDT

for the 

function f(){`
}

case it is different, we are actually failing to parse to the extent that we do not have any tokens or anything:

"Error: Line 1: Unexpected token ILLEGAL
    at throwError (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1844:21)
    at scanPunctuator (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:820:9)
    at advance (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1312:16)
    at collectToken (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1326:17)
    at lex (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1354:61)
    at expect (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:1902:21)
    at parseFunctionSourceElements (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3391:9)
    at parseFunctionDeclaration (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3533:16)
    at parseSourceElement (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3599:24)
    at parseSourceElements (http://mrennie-target.orion.eclipse.org:8080/esprima/esprima.js:3639:29)"

Comment 3 Michael Rennie

2014-09-30 14:35:16 EDT

Fix + tests:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c844052dd46baf2f1ed3f2464f27399e0f741870

The fix for the invalid '`' char does not add new recovery support for bad punctuator tokens, that work would be covered in bug 437058. Instead it augments the thrown error so we can locate the problem in the editor. The fix also adds support for showing an error on the file in the event the parser completely fails to parse and barfs.