Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 444729

Summary:

Validation points to wrong line when the problem starts at the beginning of the line

Product:

[ECD] Orion

Reporter:

Maciej Bendkowski <maciej.bendkowski>

Component:

Editor

Assignee:

Mark Macdonald <mamacdon>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

mamacdon

Version:

6.0

Target Milestone:

7.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Validator bug screen-shot	none

Description Maciej Bendkowski

2014-09-22 08:26:15 EDT

Created attachment 247274 [details]
Validator bug screen-shot

The attached screen-shot contains the exact validation problem object as specified by the validation service (http://wiki.eclipse.org/Orion/Documentation/Developer_Guide/Plugging_into_the_editor#orion.edit.validator) and the bogus marking. I noted, that adding an extra space, and thus changing the end property to 3, fixes the incorrect marking.

Comment 1 Mark Macdonald

2014-09-22 10:36:44 EDT

Off-by-1 error in syntaxchecker.js when dealing with line-based problem offsets. 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0ed5ae0

This code really needs a unit test suite -- I will create one.