Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 444276

Summary:	Package Orion client plugins as JARs
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Releng	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	6.0
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2014-09-16 12:13:44 EDT

In the Orion builds, the client bundles are packaged as directories:
 org.eclipse.orion.client.cf/
 org.eclipse.orion.client.core/
 org.eclipse.orion.client.doc/
 org.eclipse.orion.client.editor/
 org.eclipse.orion.client.git/
 org.eclipse.orion.client.javascript/
 org.eclipse.orion.client.ui/
 org.eclipse.orion.client.users/
 org.eclipse.orion.client.webtools/

They contain a ton of small files so JARs would be more efficient. Should switch them to JARs if possible.

Comment 1 Mark Macdonald

2014-09-30 14:12:36 EDT

We can't immediately jar the UI bundle, since the server-upgrade script for orion.eclipse.org relies on having the UI bundle expanded:

> #copy old server-status.json file into new server to preserve server messages
> echo Copying old server status messages into new server
> cp -f $serverHome/$oldBuildDir/plugins/org.eclipse.orion.client.ui_*/web/server-status.json \
>   $serverHome/eclipse/plugins/org.eclipse.orion.client.ui_*/web/server-status.json

This will fail if org.eclipse.orion.client.ui_* is a jar.

Comment 2 Mark Macdonald

2014-09-30 15:59:37 EDT

(In reply to Mark Macdonald from comment #1)
Released a fix to upgrade.sh that should avoid this issue for o.e.o at upgrade-time:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=2c56aab

Changed the bundles to jars:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a7fafd0

We'll run an upgrade and see how it fares.