Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 444147

Summary:	Missing manifest properties should be noted as warnings
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	Deployment	Assignee:	Maciej Bendkowski <maciej.bendkowski>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne
Version:	6.0
Target Milestone:	8.0
Hardware:	All
OS:	All
Whiteboard:

Description Maciej Bendkowski

2014-09-15 14:22:02 EDT

Some application properties might be provided at deployment, therefore missing properties in the manifest should not be noted as errors but warnings.

Comment 1 John Arthorne

2014-09-16 11:41:12 EDT

In fact maybe it shouldn't even be a warning, since the deploy wizard will prompt the user for any missing values, or they may be using a command line or deployment script that fills in the missing values. From the context of the manifest editor it is hard to conclude that a missing value is a problem.

Comment 2 Maciej Bendkowski

2014-09-16 14:23:42 EDT

(In reply to John Arthorne from comment #1)
> In fact maybe it shouldn't even be a warning, since the deploy wizard will
> prompt the user for any missing values, or they may be using a command line
> or deployment script that fills in the missing values. From the context of
> the manifest editor it is hard to conclude that a missing value is a problem.

If warnings are basically equivalent to "We found potential problems with your manifest" I'd still want them to be visible in the manifest editor. To get the warnings while writing a manifest is essentially having a running background lint. We could make this behavior configurable via settings at some point in the future.

Comment 3 Maciej Bendkowski

2014-09-22 09:03:25 EDT

I've disabled the missing "command" property warning. It should be noted, that there's only one remaining issue of this type, i.e. the missing "name" property.

Comment 4 Maciej Bendkowski

2015-01-09 12:04:39 EST

We should not provide a generic all-for-one solution to warnings and missing properties. Instead, we should re-use what we already have, i.e. deployment planners exposed via REST API. Dedicated editor plugins can consume this API and produce meaningful warnings and/or manifest errors based on the application type and other resources. Marking as closed.