Bug 444131

Description Mark Macdonald 2014-09-15 10:54:52 EDT

Recent conversions of the unit tests to mocha have caused the uiTests suite to time out and fail. It began in build #466 [1].

To reproduce:
1. Open an Incognito window and load http://[orion-server]/js-tests/ui/uiTest.html 
2. You get redirected to the login page. I expected to see the tests load and run.

The redirect causes a failure at test time, since the test runner doesn't provide the login page, nor the auth back-end, nor any way to fill in the login form.

What is happening, in detail:

1. A test case calls startup() from bootstrap.js
 -> Culprit is probably i18nTests.js, see test "I18nService"
2. bootstrap creates Plugin Registry, default plugins are loaded
3. bootstrap asks auth provider (authenticationPlugin) if user is logged in
4. authenticationPlugin calls POST /login to check

At this point the behavior differs a bit between servers: a real Orion server will send 401 Unauthorized, which causes a redirect to LoginWindow.html. The test server doesn't have a /login handler, so just returns a generic 404, which causes an unhandled rejection to the getUser() service call. In both cases the end result is the same: tests hang until timeout.

Anyway, this must be fixed. The tests cannot depend on the back end. At present this means they cannot load bootstrap.js.

[1] https://hudson.eclipse.org/orion/job/orion-client-dev/466/