Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 443592

Summary:	The SWTBot class "ViewpointSelectionDialog" does not take into account properly the viewpoints to deselect
Product:	[Modeling] Sirius	Reporter:	Mickael LANOE <mickael.lanoe>
Component:	Core	Assignee:	Project inbox <sirius.core-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	laurent.redor, pierre-charles.david, steve.monnier
Version:	1.0.1	Keywords:	triaged
Target Milestone:	2.0.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Mickael LANOE

2014-09-09 08:38:16 EDT

The method 'selectViewpoint(Set<String>, Set<String>)' in the class 'org.eclipse.sirius.tests.swtbot.support.api.dialog.ViewpointSelectionDialog', does not take into account properly the 'viewpointToDeselect' parameter.

This method contains a map with a Viewpoint for the key and a boolean for the value. The boolean value is used to select or deselect the Viewpoint key. But this value is not used to check or uncheck the table item, as you can see below:

final Map<String, Boolean> viewpointSelection = ...
final String text = item.getText(2);

if (viewpointSelection.containsKey(text)) {
    bot.table().click(rowPosition, 0);
    viewpointSelection.remove(text);
}

Comment 1 Mickael LANOE

2014-09-09 10:35:41 EDT

see https://git.eclipse.org/r/#/c/33117/

Comment 2 Mickael LANOE

2014-12-01 05:52:04 EST

fix by commit dbbff32b597356b9f61605ee5b937309c3d2700d

Comment 3 Laurent Redor

2014-12-02 08:38:09 EST

Available in Sirius 2.0.0.