Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 443560

Summary:

TVT:Concatenation found on Repositories page

Product:

[ECD] Orion

Reporter:

Baochuan Lin <baochlin>

Component:

Git

Assignee:

Project Inbox <orion.git-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

normal

Priority:

CC:

baochlin, grant_gayed, keithc, kitlo

Version:

6.0

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Concatenation	none

Description Baochuan Lin

2014-09-09 03:19:45 EDT

Created attachment 246855 [details]
Concatenation

Steps to recreate:
1、Log in the Orion(https://orionhub.org)
2、Click Git icon from the left side panel
3、Click Clone Repositroy
4、Click More
5、Enter in the Repository URL:git://github.com/kenwalker/webapp_example.git
6、Click Submit button
7、Click webapp_example
8、Expand Branches and Tags and Stashes -> local -> master -> Updated documentation


Problem Description:
Concatenation found on Repositories page

PII information is as below:
WSW44AAP001\eclipse\plugins\org.eclipse.orion.client.git\web\git\nls\root\gitmessages.js
"authoredby":"authored by: 
"on": " on",
"nameEmail": "${0} <${1}>",

These 3 PII strings shouldn't be merged to one PII string, it's a concatenation defect.

Besides, we could find another PII string "authored by 0 (1) on 2": "authored by ${0} <${1}> on ${2}" from the same file. So we think if the code should pick up this PII string not upper 3 PII strings.

Comment 1 Baochuan Lin

2014-09-09 03:26:04 EDT

Hi all,
Checked on the orion.eclipse.org server, this page has been changed, we couldn't reproduce this UI panel now, could you help confirm if we are able to reproduce this screen in latest Orion build. 
Thanks.

Comment 2 Grant Gayed

2015-05-08 12:29:00 EDT

I've confirmed that this string is no longer being used, so closing report (and I removed it from the messages.js).