Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 443286

Summary: AirDCrossReferenceAdapter installation is done too soon
Product: [Modeling] Sirius Reporter: Maxime Porhel <maxime.porhel>
Component: CoreAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 Keywords: triaged
Version: 1.0.0   
Target Milestone: 2.0.0   
Hardware: PC   
OS: Windows NT   
Whiteboard:
Bug Depends on: 437646    
Bug Blocks:    

Description Maxime Porhel CLA 2014-09-04 04:28:50 EDT
In Bug 437646, AirdDCrossReferencerAdapter installation has been moved in the session factory and a common adapter is installed on the resource set (we add previously on adapter per aird and only on AirdResourceImpl see Bug 437646). 

It is done juste after the resource set creation (by resource set factory which uses the first found extension) but just after the add of the adapter, we create the editing domain: we call the EditingDomainInFactoryService, which looks in the extension the 'first most overrider' factory and create an editing domain. The creation has the previously created set, but the created editing domain can use its own resource set. 

Our adapter installation is done too soon. This typically occurs with Capella which does not use one editing domain per session, but has its own shared editing domain.
Comment 1 Maxime Porhel CLA 2014-09-04 04:33:10 EDT
See https://git.eclipse.org/r/32839
Comment 2 Maxime Porhel CLA 2014-09-15 04:46:31 EDT
Corrected by commit 81e0e354590d30c92b7ce77c7ed0a2a276f1fcb1
Comment 3 Pierre-Charles David CLA 2014-10-27 06:52:05 EDT
Available in Sirius 2.0.0.